Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2024-10-27 20:44:07 +00:00
Code Issues Projects Releases Wiki Activity

(core) Hiding expand button if there is single widget on a page

Browse Source 
Summary:
Expand button on a page with a single widget seems pointless and presents a bad UX when
embedded.

Test Plan: new tests

Reviewers: georgegevoian

Reviewed By: georgegevoian

Subscribers: georgegevoian

Differential Revision: https://phab.getgrist.com/D4020
This commit is contained in:
Jarosław Sadziński 2023-08-30 10:02:25 +02:00
parent 58323f5313
commit 98068cb86c
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
app/client/ui/ViewSectionMenu.ts
View File

@ -55,12 +55,22 @@ export function viewSectionMenu(
const save = () => { doSave(docModel, viewSection).catch(reportError); }; const save = () => { doSave(docModel, viewSection).catch(reportError); };
const revert = () => doRevert(viewSection); const revert = () => doRevert(viewSection);
// If this section is the only one in the view (or view temporary has no sections at all).
const singleVisible = Computed.create(owner, (use) => {
const view = use(viewSection.view);
const sections = use(use(view.viewSections).getObservable());
const expanded = sections.filter(s => use(s.isCollapsed) === false).length;
return expanded === 1 || !expanded; // single, or no sections at all (temporary).
});
// Should we show expand icon. // Should we show expand icon.
const showExpandIcon = Computed.create(owner, (use) => { const showExpandIcon = Computed.create(owner, (use) => {
return !use(isNarrowScreenObs()) // not on narrow screens return !use(isNarrowScreenObs()) // not on narrow screens
&& use(gristDoc.maximizedSectionId) !== use(viewSection.id) // not in when we are maximized && use(gristDoc.maximizedSectionId) !== use(viewSection.id) // not in when we are maximized
&& use(gristDoc.externalSectionId) !== use(viewSection.id) // not in when we are external && use(gristDoc.externalSectionId) !== use(viewSection.id) // not in when we are external
&& !use(viewSection.isRaw); // not in raw mode && !use(viewSection.isRaw) // not in raw mode
&& !use(singleVisible) // not in single section
;
}); });
return [ return [