Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2024-10-27 20:44:07 +00:00
Code Issues Projects Releases Wiki Activity

(core) fix closing of the search bar

Browse Source 
Summary:
   - Sending `ESCAPE` while hovering the options panel was not working
   - This is because of the keepExpanded flag which was set to true
   - Solution is to set the keepExpanded flag to false, prior to toggling the Menu

Test Plan:  - Tested manually

Reviewers: paulfitz

Reviewed By: paulfitz

Differential Revision: https://phab.getgrist.com/D2836
This commit is contained in:
Cyprien P 2021-05-25 14:24:36 +02:00
parent 7758cb830d
commit 8c6148dd9f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/client/ui2018/search.ts
View File

@ -144,7 +144,7 @@ export function searchBar(model: SearchModel, testId: TestId = noTestId) {
)), )),
dom.onKeyDown({ dom.onKeyDown({
Enter: () => model.findNext(), Enter: () => model.findNext(),
Escape: () => toggleMenu(false), Escape: () => { keepExpanded = false; toggleMenu(false); },
// Catch both Tab and Shift+Tab to prevent focus entering unrelated editable label. // Catch both Tab and Shift+Tab to prevent focus entering unrelated editable label.
Tab: () => toggleMenu(false), Tab: () => toggleMenu(false),
}), }),