Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2024-10-27 20:44:07 +00:00
Code Issues Projects Releases Wiki Activity

(core) mark engine setting as experimental

Browse Source 
Summary:
This marks the engine setting in document settings as experimental,
with a skull and cross-bones.

It also makes sure the setting is shown if PYTHON_VERSION_ON_CREATION
is set (this relates to a separate change to set the default python
version to 3).

Test Plan: manual

Reviewers: alexmojaki, dsagal

Reviewed By: alexmojaki, dsagal

Subscribers: anaisconce

Differential Revision: https://phab.getgrist.com/D3120
This commit is contained in:
Paul Fitzpatrick 2021-11-04 18:10:15 -04:00
parent 4ddc29fb40
commit 877542225d
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/client/ui/DocumentSettings.ts
View File

@ -52,7 +52,7 @@ export async function showDocSettingsModal(docInfo: DocInfoRec, docPageModel: Do
{defaultCurrencyLabel: `Local currency (${getCurrency(l)})`}) {defaultCurrencyLabel: `Local currency (${getCurrency(l)})`})
)), )),
canChangeEngine ? [ canChangeEngine ? [
cssDataRow('Engine:'), cssDataRow('Engine (experimental ☠ change at own risk):'),
select(engineObs, getSupportedEngineChoices()), select(engineObs, getSupportedEngineChoices()),
] : null, ] : null,
], ],

3
app/server/lib/serverUtils.ts
View File

@ -155,7 +155,8 @@ export function getLogMetaFromDocSession(docSession: OptDocSession) {
* Only offer choices of engine on experimental deployments (staging/dev). * Only offer choices of engine on experimental deployments (staging/dev).
*/ */
export function getSupportedEngineChoices(): EngineCode[]|undefined { export function getSupportedEngineChoices(): EngineCode[]|undefined {
if (process.env.GRIST_EXPERIMENTAL_PLUGINS === '1') { if (process.env.GRIST_EXPERIMENTAL_PLUGINS === '1' ||
process.env.PYTHON_VERSION_ON_CREATION) {
return ['python2', 'python3']; return ['python2', 'python3'];
} }
return undefined; return undefined;