Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2026-03-02 04:09:24 +00:00
Code Issues Projects Releases Wiki Activity

(core) When a page starts with a number, don't treat it as an emoji

Browse Source 
Test Plan: Added a check to the emoji test.

Reviewers: georgegevoian

Reviewed By: georgegevoian

Subscribers: georgegevoian

Differential Revision: https://phab.getgrist.com/D3951
This commit is contained in:
Dmitry S
2023-07-12 14:38:03 -04:00
parent b2743cac2d
commit 8581492912
2 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
test/nbrowser/Pages.ts
View File

@@ -266,7 +266,7 @@ describe('Pages', function() {
// It looks like our version of Chromedriver does not support sending emojis using sendKeys
// (issue mentioned here https://stackoverflow.com/a/59139690), so we'll use executeScript to
// rename pages.
async function renamePage(origName: string, newName: string) {
async function renamePage(origName: string|RegExp, newName: string) {
await gu.openPageMenu(origName);
await driver.find('.test-docpage-rename').doClick();
const editor = await driver.find('.test-docpage-editor');
@@ -291,7 +291,11 @@ describe('Pages', function() {
assert.deepEqual(await getInitialAndName(/Guest List/),
['👨‍👩‍👧‍👦', '👨‍👩‍👧Guest List']);
await gu.undo(2);
// Digits should not be considered emoji (even though they match /\p{Emoji}/...)
await renamePage(/Guest List/, '5Guest List');
assert.deepEqual(await getInitialAndName(/Guest List/), ['5', '5Guest List']);
await gu.undo(3);
assert.deepEqual(await getInitialAndName(/People/), ['P', 'People']);
});