Summary: - test/nbrowser/CustomFilter keeps randomly fail on my local dev - it failed with `Cannot read property of null (reading 'postMessage`)` at line below: `this._rpc.setSendMessage(msg => this._iframe?.contentWindow!.postMessage(msg, '*'));` - I understand it was trying to send message before even the iframe was properly mounted - telling rpc to wait for the other end to send ready() successfully differ send message until everything's mounted. Test Plan: - should not break anything and test/nbrowser/CustomFilter should stop failing Reviewers: jarek Reviewed By: jarek Subscribers: jarek Differential Revision: https://phab.getgrist.com/D3510pull/214/head
parent
51ff72c15e
commit
808aacdc52
Loading…
Reference in new issue