Adding eslint to github actions

.github/workflows/main.yml

@@ -46,6 +46,9 @@ jobs:
       - name: Build Node.js code
         run: yarn run build:prod
 
+      - name: Run eslint
+        run: yarn run lint:ci
+
       - name: Run smoke test
         run: VERBOSE=1 DEBUG=1 MOCHA_WEBDRIVER_HEADLESS=1 yarn run test:smoke
 

app/server/lib/HostedStorageManager.ts

@@ -923,7 +923,7 @@ export async function backupSqliteDatabase(src: string, dest: string,
   } finally {
     if (testProgress) { testProgress({action: 'close', phase: 'before'}); }
     try {
-      if (db) { await fromCallback(cb => db.close(cb)); }
+      if (db) { await fromCallback(cb => db!.close(cb)); }
     } catch (err) {
       _log.debug(null, `problem stopping copy of ${src} (${label}): ${err}`);
     }

package.json

@@ -22,8 +22,9 @@
     "test:python": "sandbox_venv3/bin/python sandbox/grist/runtests.py ${GREP_TESTS:+discover -p \"test*${GREP_TESTS}*.py\"}",
     "cli": "NODE_PATH=_build:_build/stubs:_build/ext node _build/app/server/companion.js",
     "lint": "eslint --cache --cache-strategy content .",
-    "lint:fix": "eslint  --cache --cache-strategy content --fix .",
-    "generate:translation": "NODE_PATH=_build:_build/stubs:_build/ext node buildtools/generate_translation_keys.js"
+    "lint:fix": "eslint  --cache --cache-strategy=content --fix .",
+    "lint:ci": "eslint --max-warnings=0 .",
+    "generate:translation": "NODE_PATH=_build:_build/stubs:_build/ext node buildtools/generate_translation_keys.js",
   },
   "keywords": [
     "grist",