Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2026-03-02 04:09:24 +00:00
Code Issues Projects Releases Wiki Activity

(core) Fixing bug with the import preview being not responsive

Browse Source 
Summary: Fixing the bug by setting viewInstance on the temp viewsection record

Test Plan: Added

Reviewers: dsagal

Reviewed By: dsagal

Subscribers: dsagal

Differential Revision: https://phab.getgrist.com/D3848
This commit is contained in:
Jarosław Sadziński
2023-04-04 09:51:34 +02:00
parent 5730262c69
commit 7aa83858bd
2 changed files with 23 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
test/nbrowser/gristUtils.ts
View File

@@ -248,6 +248,7 @@ export async function expandSection(title?: string) {
? driver.findContent(`.test-viewsection-title`, exactMatch(title)).findClosest(".viewsection_title")
: driver.find(".active_section");
await select.find(".test-section-menu-expandSection").click();
await driver.findWait('.test-viewLayout-overlay .test-close-button', 500);
}
export async function getSectionId() {
@@ -541,9 +542,9 @@ export async function rightClick(cell: WebElement) {
* section. RowNum is a 1-based number as in the row headers, and col is a 0-based index for
* grid view or field name for detail view.
*/
export async function getCursorPosition() {
export async function getCursorPosition(section?: WebElement) {
return await retryOnStale(async () => {
const section = await driver.findWait('.active_section', 4000);
section = section ?? await driver.findWait('.active_section', 4000);
const cursor = await section.findWait('.active_cursor', 1000);
// Query assuming the cursor is in a GridView and a DetailView, then use whichever query data
// works out.