Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2026-03-02 04:09:24 +00:00
Code Issues Projects Releases Wiki Activity

(core) Port LinkingState.js to TypeScript

Browse Source 
Summary: Converted LinkingState from constructor function to class.

Test Plan: no

Reviewers: dsagal

Reviewed By: dsagal

Differential Revision: https://phab.getgrist.com/D2997
This commit is contained in:
Alex Hall
2021-08-26 13:39:17 +02:00
parent faa0d9988e
commit 7465af8ce8
5 changed files with 149 additions and 150 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
app/client/components/BaseView.js
View File

@@ -14,8 +14,8 @@ var Base = require('./Base');
var {Cursor} = require('./Cursor');
var FieldBuilder = require('../widgets/FieldBuilder');
var commands = require('./commands');
var LinkingState = require('./LinkingState');
var BackboneEvents = require('backbone').Events;
const {LinkingState} = require('./LinkingState');
const {ClientColumnGetters} = require('app/client/models/ClientColumnGetters');
const {reportError, UserError} = require('app/client/models/errors');
const {urlState} = require('app/client/models/gristUrlState');
@@ -131,13 +131,12 @@ function BaseView(gristDoc, viewSectionModel, options) {
this._linkingState = this.autoDispose(koUtil.computedBuilder(() => {
let v = this.viewSection;
let src = v.linkSrcSection();
const filterByAllShown = v.optionsObj.prop('filterByAllShown');
if (!src.getRowId()) {
return null;
}
try {
const config = new LinkConfig(v);
return LinkingState.create.bind(LinkingState, this.gristDoc, config, filterByAllShown());
return LinkingState.create.bind(LinkingState, null, this.gristDoc, config);
} catch (err) {
console.warn(`Can't create LinkingState: ${err.message}`);
return null;