(core) Remove forms popup

Summary: The forms announcement popup should no longer be shown.

Test Plan: N/A

Reviewers: paulfitz

Reviewed By: paulfitz

Subscribers: paulfitz

Differential Revision: https://phab.getgrist.com/D4229

app/client/models/DocPageModel.ts

@@ -221,11 +221,6 @@ export class DocPageModelImpl extends Disposable implements DocPageModel {
             // "Add New" menu should have the same width as the "Add New" button that opens it.
             stretchToSelector: `.${cssAddNewButton.className}`
           }),
-          activeDoc.behavioralPromptsManager.attachPopup('formsAreHere', {
-            popupOptions: {
-              placement: 'right',
-            },
-          }),
           testId('dp-add-new'),
           dom.cls('tour-add-new'),
         ),

app/client/ui/GristTooltips.ts

@@ -1,7 +1,6 @@
 import * as commands from 'app/client/components/commands';
 import {makeT} from 'app/client/lib/localization';
 import {ShortcutKey, ShortcutKeyContent} from 'app/client/ui/ShortcutKey';
-import {basicButtonLink} from 'app/client/ui2018/buttons';
 import {icon} from 'app/client/ui2018/icons';
 import {cssLink} from 'app/client/ui2018/links';
 import {commonUrls, GristDeploymentType} from 'app/common/gristUrls';
@@ -29,17 +28,6 @@ const cssIcon = styled(icon, `
   width: 18px;
 `);
 
-const cssNewsPopupLearnMoreButton = styled(basicButtonLink, `
-  color: white;
-  border: 1px solid white;
-  padding: 3px;
-
-  &:hover, &:focus, &:visited {
-    color: white;
-    border-color: white;
-  }
-`);
-
 export type Tooltip =
   | 'dataSize'
   | 'setTriggerFormula'
@@ -321,19 +309,4 @@ data.")),
     ),
     deploymentTypes: ['saas', 'core', 'enterprise', 'electron'],
   },
-  formsAreHere: {
-    popupType: 'news',
-    audience: 'signed-in-users',
-    title: () => t('Forms are here!'),
-    content: (...args: DomElementArg[]) => cssTooltipContent(
-      dom('div', t('Build simple forms right in Grist and share in a click with our new widget. {{learnMoreButton}}', {
-        learnMoreButton: cssNewsPopupLearnMoreButton(t('Learn more'), {
-          href: commonUrls.forms,
-          target: '_blank',
-        }),
-      })),
-      ...args,
-    ),
-    deploymentTypes: ['saas', 'core', 'enterprise'],
-  },
 };

app/common/Prefs.ts

@@ -88,7 +88,9 @@ export const BehavioralPrompt = StringUnion(
   'rickRow',
   'customURL',
   'calendarConfig',
-  'formsAreHere',
+
+  // The following were used in the past and should not be re-used.
+  // 'formsAreHere',
 );
 export type BehavioralPrompt = typeof BehavioralPrompt.type;
 

test/nbrowser/BehavioralPrompts.ts

@@ -39,11 +39,6 @@ describe('BehavioralPrompts', function() {
     });
   });
 
-  it('should show an announcement for forms', async function() {
-    await assertPromptTitle('Forms are here!');
-    await gu.dismissBehavioralPrompts();
-  });
-
   describe('when anonymous', function() {
     before(async () => {
       const anonymousSession = await gu.session().anon.login({