mirror of
https://github.com/gristlabs/grist-core.git
synced 2026-03-02 04:09:24 +00:00
(core) Raw renames
Summary: A new way for renaming tables. - There is a new popup to rename section (where you can also rename the table) - Renaming/Deleting page doesn't modify/delete the table. - Renaming table can rename a page if the names match (and the page contains a section with that table). - User can rename table in Raw Data UI in two ways - either on the listing or by using the section name popup - As before, there is no way to change tableId - it is derived from a table name. - When the section name is empty the table name is shown instead. - White space for section name is allowed (to discuss) - so the user can just paste ' '. - Empty name for a page is not allowed (but white space is). - Some bugs related to deleting tables with attached summary tables (and with undoing this operation) were fixed (but not all of them yet). Test Plan: Updated tests. Reviewers: georgegevoian Reviewed By: georgegevoian Subscribers: georgegevoian Differential Revision: https://phab.getgrist.com/D3360
This commit is contained in:
@@ -62,7 +62,7 @@ function BaseView(gristDoc, viewSectionModel, options) {
|
||||
if (this.viewSection.table().summarySourceTable()) {
|
||||
const groupGetter = this.tableModel.tableData.getRowPropFunc('group');
|
||||
this._mainRowSource = rowset.BaseFilteredRowSource.create(this,
|
||||
rowId => !gristTypes.isEmptyList(groupGetter(rowId)));
|
||||
rowId => !groupGetter || !gristTypes.isEmptyList(groupGetter(rowId)));
|
||||
this._mainRowSource.subscribeTo(this._queryRowSource);
|
||||
} else {
|
||||
this._mainRowSource = this._queryRowSource;
|
||||
|
||||
Reference in New Issue
Block a user