(core) Switch excel import parsing from messytables+xlrd to openpyxl, and ignore empty rows

Browse Source

Summary:
Use openpyxl instead of messytables (which used xlrd internally) in import_xls.py.

Skip empty rows since excel files can easily contain huge numbers of them.

Drop support for xls files (which openpyxl doesn't support) in favour of the newer xlsx format.

Fix some details relating to python virtualenvs and dependencies, as Jenkins was failing to find new Python dependencies.

Test Plan: Mostly relying on existing tests. Updated various tests which referred to xls files instead of xlsx. Added a Python test for skipping empty rows.

Reviewers: georgegevoian

Reviewed By: georgegevoian

Differential Revision: https://phab.getgrist.com/D3406

...

This commit is contained in:

Alex Hall

2022-05-06 17:26:45 +02:00

parent 0a61d740ba

commit 6c90de4d62

15 changed files with 127 additions and 135 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

BIN

sandbox/grist/imports/fixtures/test_empty_rows.xlsx Normal file

Binary file not shown.