Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2024-10-27 20:44:07 +00:00
Code Issues Projects Releases Wiki Activity

(core) Fix for the creator panel on custom section.

Browse Source 
Summary: Stop opening the creator panel on chart or custom widgets. Only switch tabs when panel is open

Test Plan: Updated

Reviewers: georgegevoian

Reviewed By: georgegevoian

Differential Revision: https://phab.getgrist.com/D3868
This commit is contained in:
Jarosław Sadziński 2023-04-18 13:43:29 +02:00
parent f490854324
commit 69fea132de
2 changed files with 9 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
app/client/components/GristDoc.ts
View File

@ -518,17 +518,8 @@ export class GristDoc extends DisposableWithEvents {
// panel to the table. // panel to the table.
this.autoDispose(this.viewModel.activeSection.subscribe((section) => { this.autoDispose(this.viewModel.activeSection.subscribe((section) => {
if (section.isDisposed() || section._isDeleted.peek()) { return; } if (section.isDisposed() || section._isDeleted.peek()) { return; }
if ('chart' === section.parentKey.peek()) { if (['chart', 'custom'].includes(section.parentKey.peek())) {
commands.allCommands.viewTabFocus.run(); commands.allCommands.viewTabFocus.run();
} else if ('custom' === section.parentKey.peek()) {
// Check if user has seen custom URL tooltip.
const seenTooltip = this.behavioralPromptsManager.hasSeenTip('customURL');
// If yes, just focus on the table if it is opened
if (seenTooltip) {
commands.allCommands.viewTabFocus.run();
} else {
commands.allCommands.viewTabOpen.run();
}
} }
})); }));
} }

9
test/nbrowser/RightPanel.ts
View File

@ -12,11 +12,18 @@ describe('RightPanel', function() {
const mainSession = await gu.session().teamSite.login(); const mainSession = await gu.session().teamSite.login();
await mainSession.tempNewDoc(cleanup); await mainSession.tempNewDoc(cleanup);
// Reset prefs.
await driver.executeScript('resetSeenPopups();');
await gu.waitForServer();
// Refresh for a clean start.
await gu.reloadDoc();
// Close panel and make sure it stays closed. // Close panel and make sure it stays closed.
await gu.toggleSidePanel('right', 'close'); await gu.toggleSidePanel('right', 'close');
// Add a chart section. // Add a chart section.
await gu.addNewSection('Chart', 'Table1'); await gu.addNewSection('Chart', 'Table1', { dismissTips: true});
assert.isFalse(await gu.isSidePanelOpen('right')); assert.isFalse(await gu.isSidePanelOpen('right'));
await gu.undo(); await gu.undo();