Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2024-10-27 20:44:07 +00:00
Code Issues Projects Releases Wiki Activity

(core) Limit related videos when playing onboarding video tour from home page

Browse Source 
Summary:
When video is opened from the app homepage, it opens in a popup, which stays
open when it ends. The rel=0 parameter limits the related videos shown at the
end to those from the same channel, avoiding surprising unrelated videos.

This doesn't affect the video shown during initial onboarding, since that once
auto-closes when it ends.

Test Plan: Tested manually

Reviewers: georgegevoian

Reviewed By: georgegevoian

Differential Revision: https://phab.getgrist.com/D4313
This commit is contained in:
Dmitry S 2024-08-08 01:04:44 -04:00
parent 9b8d0c9fac
commit 69aabd1ae0
2 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/client/ui/OpenVideoTour.ts
View File

@ -26,6 +26,9 @@ const testId = makeTestId('test-video-tour-');
height: '100%', height: '100%',
width: '100%', width: '100%',
origin: getMainOrgUrl(), origin: getMainOrgUrl(),
playerVars: {
rel: 0,
},
}, },
cssYouTubePlayer.cls(''), cssYouTubePlayer.cls(''),
); );

1
app/client/ui/YouTubePlayer.ts
View File

@ -29,6 +29,7 @@ export interface PlayerVars {
fs?: 0 | 1; fs?: 0 | 1;
iv_load_policy?: 1 | 3; iv_load_policy?: 1 | 3;
modestbranding?: 0 | 1; modestbranding?: 0 | 1;
rel?: 0 | 1;
} }
export interface PlayerStateChangeEvent { export interface PlayerStateChangeEvent {