mirror of
https://github.com/gristlabs/grist-core.git
synced 2026-03-02 04:09:24 +00:00
(core) Readonly editors
Summary: Grist should not prevent read-only viewers from opening cell editors since they usually provide much more information than is visible in a cell. Every editor was enhanced with a read-only mode that provides the same information available for an editor but doesn't allow to change the underlying data. Test Plan: Browser tests Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2842
This commit is contained in:
@@ -331,6 +331,12 @@ export async function getColumnNames() {
|
||||
.filter(name => name !== '+');
|
||||
}
|
||||
|
||||
export async function getCardFieldLabels() {
|
||||
const section = await driver.findWait('.active_section', 4000);
|
||||
const labels = await section.findAll(".g_record_detail_label", el => el.getText());
|
||||
return labels;
|
||||
}
|
||||
|
||||
/**
|
||||
* Resize the given grid column by a given number of pixels.
|
||||
*/
|
||||
@@ -371,6 +377,12 @@ export async function getCursorPosition() {
|
||||
// This must be a detail view, and we just got the info we need.
|
||||
return {rowNum: parseInt(rowNum, 10), col: colName};
|
||||
} else {
|
||||
// We might be on a single card record
|
||||
const counter = await section.findAll(".grist-single-record__menu__count");
|
||||
if (counter.length) {
|
||||
const cardRow = (await counter[0].getText()).split(' OF ')[0];
|
||||
return { rowNum : parseInt(cardRow), col: colName };
|
||||
}
|
||||
// Otherwise, it's a grid view, and we need to use indices to look up the info.
|
||||
const gridRows = await section.findAll('.gridview_data_row_num');
|
||||
const gridRowNum = await gridRows[rowIndex].getText();
|
||||
|
||||
Reference in New Issue
Block a user