Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2024-10-27 20:44:07 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #412 from incubateur-territoires/bug-card-empty-reference

Browse Source 
Bug card empty reference
This commit is contained in:
jarek 2023-02-03 19:14:11 +01:00 committed by GitHub
commit 65c8bec2b4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 19 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/client/components/BaseView.js
View File

@ -141,7 +141,7 @@ function BaseView(gristDoc, viewSectionModel, options) {
}).extend({deferred: true})); }).extend({deferred: true}));
// Update the cursor whenever linkedRowId() changes. // Update the cursor whenever linkedRowId() changes.
this.autoDispose(this.linkedRowId.subscribe(rowId => this.setCursorPos({rowId}))); this.autoDispose(this.linkedRowId.subscribe(rowId => this.setCursorPos({rowId: rowId || 'new'})));
// Indicated whether editing the section should be disabled given the current linking state. // Indicated whether editing the section should be disabled given the current linking state.
this.disableEditing = this.autoDispose(ko.computed(() => { this.disableEditing = this.autoDispose(ko.computed(() => {

BIN
test/fixtures/docs/Favorite_Films_With_Linked_Ref.grist vendored Normal file
View File

Binary file not shown.

19
test/nbrowser/ReferenceColumns.ts
View File

@ -11,7 +11,7 @@ describe('ReferenceColumns', function() {
describe('rendering', function() { describe('rendering', function() {
before(async function() { before(async function() {
session = await gu.session().teamSite.login(); session = await gu.session().teamSite.login();
await session.tempDoc(cleanup, 'Favorite_Films.grist'); await session.tempDoc(cleanup, 'Favorite_Films_With_Linked_Ref.grist');
await gu.toggleSidePanel('right'); await gu.toggleSidePanel('right');
await driver.find('.test-config-data').click(); await driver.find('.test-config-data').click();
@ -147,6 +147,23 @@ describe('ReferenceColumns', function() {
] ]
); );
}); });
it('should have linked card for friends', async () => {
// Open the All page.
await driver.findContentWait('.test-treeview-itemHeader', /Linked Friends/, 2000).click();
await gu.waitForDocToLoad();
await driver.findContentWait('.field_clip', /Mary/, 2000).click();
await gu.waitForServer();
await driver.findContentWait('.g_record_detail_label', /Title/, 2000).click();
assert.equal(await gu.getActiveCell().getText(), 'Alien');
await driver.findContentWait('.field_clip', /Jarek/, 2000).click();
await gu.waitForServer();
await driver.findContentWait('.g_record_detail_label', /Title/, 2000).click();
assert.equal(await gu.getActiveCell().getText(), '');
});
}); });
describe('autocomplete', function() { describe('autocomplete', function() {