Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2026-03-02 04:09:24 +00:00
Code Issues Projects Releases Wiki Activity

support $id in dropdown condition (#969)

Browse Source 
This adds support for $id in dropdown conditions, using the same
method used for supporting referencedColumn.id, and extends a test
to exercise the variable. Without this, the dropdown editor gives
an error if $id or rec.id is used, stating that the column is invalid.
This commit is contained in:
Paul Fitzpatrick
2024-05-07 17:52:51 -04:00
committed by GitHub
parent 9a89901042
commit 6299db6872
2 changed files with 21 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/client/components/DropdownConditionConfig.ts
View File

@@ -51,7 +51,7 @@ export class DropdownConditionConfig extends Disposable {
const {recColIds = [], choiceColIds = []} = properties;
const columns = use(this._columns);
const validRecColIds = new Set(columns.map((({colId}) => use(colId))));
const validRecColIds = new Set(['id', ...columns.map((({colId}) => use(colId)))]);
const invalidRecColIds = recColIds.filter(colId => !validRecColIds.has(colId));
if (invalidRecColIds.length > 0) {
return t('Invalid columns: {{colIds}}', {colIds: invalidRecColIds.join(', ')});