(core) Fix reporting of errors when saving cells by clicking away, and deduplicate memos.

Test Plan: Enhanced the test case for memos to check these cases too (fails without this fix).

Reviewers: paulfitz

Reviewed By: paulfitz

Differential Revision: https://phab.getgrist.com/D2876

app/client/widgets/FieldEditor.ts

@@ -443,8 +443,10 @@ function setupReadonlyEditorCleanup(
  * - Arrange for UnsavedChange protection against leaving the page with unsaved changes.
  */
 function setupEditorCleanup(
-  owner: MultiHolder, gristDoc: GristDoc, field: ViewFieldRec, saveEdit: () => Promise<unknown>
+  owner: MultiHolder, gristDoc: GristDoc, field: ViewFieldRec, _saveEdit: () => Promise<unknown>
 ) {
+  const saveEdit = () => _saveEdit().catch(reportError);
+
   // Whenever focus returns to the Clipboard component, close the editor by saving the value.
   gristDoc.app.on('clipboard_focus', saveEdit);
 

app/server/lib/PermissionInfo.ts

@@ -25,11 +25,17 @@ export type PermissionSetWithContext = PermissionSetWithContextOf<PermissionSet<
 // Accumulator for memos of relevant rules.
 export type MemoSet = PermissionSet<string[]>;
 
-// Merge MemoSets straightforwardly, by concatenation.
+// Merge MemoSets by collecting all memos with de-duplication.
 export function mergeMemoSets(psets: MemoSet[]): MemoSet {
   const result: Partial<MemoSet> = {};
   for (const prop of ALL_PERMISSION_PROPS) {
-    result[prop] = ([] as string[]).concat(...psets.map(p => p[prop]));
+    const merged = new Set<string>();
+    for (const p of psets) {
+      for (const memo of p[prop]) {
+        merged.add(memo);
+      }
+    }
+    result[prop] = [...merged];
   }
   return result as MemoSet;
 }