Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2024-10-27 20:44:07 +00:00
Code Issues Projects Releases Wiki Activity

(core) Tweak placement and title of filters tip

Browse Source 
Summary:
The pinning filters tip is now shown to the right by default, and
has a new title.

Test Plan: Tested manually.

Reviewers: jarek

Reviewed By: jarek

Differential Revision: https://phab.getgrist.com/D3743
This commit is contained in:
George Gevoian 2022-12-21 22:36:26 -05:00
parent cabac3d9d8
commit 5b9242fa7c
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/client/ui/ColumnFilterMenu.ts
View File

@ -355,7 +355,13 @@ export function columnFilterMenu(owner: IDisposableOwner, opts: IFilterMenuOptio
gristDoc.behavioralPrompts.attachTip('filterButtons', { gristDoc.behavioralPrompts.attachTip('filterButtons', {
popupOptions: { popupOptions: {
attach: null, attach: null,
} modifiers: {
flip: {
behavior: ['right', 'top'],
},
},
placement: 'right',
},
}), }),
testId('pin-btn'), testId('pin-btn'),
), ),

2
app/client/ui/GristTooltips.ts
View File

@ -146,7 +146,7 @@ export const GristBehavioralPrompts: Record<BehavioralPrompt, BehavioralPromptCo
), ),
}, },
filterButtons: { filterButtons: {
title: 'Filter Buttons', title: 'Pinning Filters',
content: (...args: DomElementArg[]) => cssTooltipContent( content: (...args: DomElementArg[]) => cssTooltipContent(
dom('div', 'Pinned filters are displayed as buttons above the widget.'), dom('div', 'Pinned filters are displayed as buttons above the widget.'),
dom('div', 'Unpin to hide the the button while keeping the filter.'), dom('div', 'Unpin to hide the the button while keeping the filter.'),