Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2024-10-27 20:44:07 +00:00
Code Issues Projects Releases Wiki Activity

Fixes linking "srcSection disposed" bug (#670)

Browse Source 
Test "RawData should remove all tables except one (including referenced
summary table)"

was failing with error: "this._srcSection.activeRowId is not a function"
added an extra isDisposed check to catch it
This commit is contained in:
Janet Vorobyeva 2023-09-12 00:15:10 -04:00 committed by GitHub
parent 5d7ef23433
commit 5a4433c60c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
app/client/components/LinkingState.ts
View File

@ -308,10 +308,17 @@ export class LinkingState extends Disposable {
//(we autodispose/return it at the end of the function) is this right? TODO JV //(we autodispose/return it at the end of the function) is this right? TODO JV
return owner.autoDispose(ko.computed(() => { return owner.autoDispose(ko.computed(() => {
if (this._srcSection.isDisposed()) {
//happened transiently in test: "RawData should remove all tables except one (...)"
console.warn("LinkingState._makeFilterObs: srcSectionDisposed");
return EmptyFilterState;
}
//Get selector-rowId //Get selector-rowId
const srcRowId = this._srcSection.activeRowId(); const srcRowId = this._srcSection.activeRowId();
if (srcRowId === null) { if (srcRowId === null) {
console.warn("_makeFilterObs activeRowId is null"); console.warn("LinkingState._makeFilterObs activeRowId is null");
return EmptyFilterState; return EmptyFilterState;
} }