Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2024-10-27 20:44:07 +00:00
Code Issues Projects Releases Wiki Activity

(core) Show coaching popup after Add New tip is dismissed

Browse Source 
Summary:
This is to prevent too many popups from being shown on screen at any
given moment.

Test Plan: Tested manually.

Reviewers: jarek

Reviewed By: jarek

Differential Revision: https://phab.getgrist.com/D3841
This commit is contained in:
George Gevoian 2023-03-29 09:14:30 -04:00
parent a317a727c8
commit 58ef8d59b5
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/client/components/BehavioralPromptsManager.ts
View File

@ -63,6 +63,10 @@ export class BehavioralPromptsManager extends Disposable {
return this._dismissedTips.get().has(prompt); return this._dismissedTips.get().has(prompt);
} }
public shouldShowTips() {
return !this._prefs.get().dontShowTips;
}
private _queueTip(refElement: Element, prompt: BehavioralPrompt, options: AttachOptions) { private _queueTip(refElement: Element, prompt: BehavioralPrompt, options: AttachOptions) {
if ( if (
// Don't show tips if surveying is disabled. // Don't show tips if surveying is disabled.

2
test/nbrowser/gristUtils.ts
View File

@ -751,7 +751,7 @@ export async function reloadDoc() {
* Wait for the doc list to show, to know that workspaces are fetched, and imports enabled. * Wait for the doc list to show, to know that workspaces are fetched, and imports enabled.
*/ */
export async function waitForDocMenuToLoad(): Promise<void> { export async function waitForDocMenuToLoad(): Promise<void> {
await driver.findWait('.test-dm-doclist', 1000); await driver.findWait('.test-dm-doclist', 2000);
await driver.wait(() => driver.find('.test-dm-doclist').isDisplayed(), 2000); await driver.wait(() => driver.find('.test-dm-doclist').isDisplayed(), 2000);
} }