mirror of
https://github.com/gristlabs/grist-core.git
synced 2026-03-02 04:09:24 +00:00
(core) Update logging in sandbox code, and log tracebacks as single log messages.
Summary: - Replace logger module by the standard module 'logging'. - When a log message from the sandbox includes newlines (e.g. for tracebacks), keep those lines together in the Node log message. Previously each line was a different message, making it difficult to view tracebacks, particularly in prod where each line becomes a separate message object. - Fix assorted lint errors. Test Plan: Added a test for the log-line splitting and escaping logic. Reviewers: georgegevoian Reviewed By: georgegevoian Differential Revision: https://phab.getgrist.com/D3956
This commit is contained in:
@@ -2,6 +2,7 @@ import ast
|
||||
import contextlib
|
||||
import itertools
|
||||
import linecache
|
||||
import logging
|
||||
import re
|
||||
import textwrap
|
||||
|
||||
@@ -11,8 +12,7 @@ import six
|
||||
|
||||
import friendly_errors
|
||||
import textbuilder
|
||||
import logger
|
||||
log = logger.Logger(__name__, logger.INFO)
|
||||
log = logging.getLogger(__name__)
|
||||
|
||||
|
||||
DOLLAR_REGEX = re.compile(r'\$(?=[a-zA-Z_][a-zA-Z_0-9]*)')
|
||||
|
||||
Reference in New Issue
Block a user