Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2024-10-27 20:44:07 +00:00
Code Issues Projects Releases Wiki Activity

(core) Use different user in ActionLog tests

Browse Source 
Summary:
Nearby deployment tests used the same user, which was
causing the full suite to fail. Repeated logins with a second
verification step (TOTP) fail in Cognito if the same verification code
is used twice. This happened to be the case since the gap
between tests wasn't long enough for a new code to be generated.

Test Plan: Manually verified deployment tests now pass.

Reviewers: jarek

Reviewed By: jarek

Differential Revision: https://phab.getgrist.com/D3414
This commit is contained in:
George Gevoian 2022-05-05 13:33:27 -07:00
parent db57815d2b
commit 52eb5325c2
2 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/nbrowser/ActionLog.ts
View File

@ -24,7 +24,7 @@ describe('ActionLog', function() {
} }
before(async function() { before(async function() {
const session = await gu.session().user('user4').login(); const session = await gu.session().user('user1').login();
await session.tempDoc(cleanup, 'Hello.grist'); await session.tempDoc(cleanup, 'Hello.grist');
await gu.dismissWelcomeTourIfNeeded(); await gu.dismissWelcomeTourIfNeeded();
}); });

10
test/nbrowser/homeUtil.ts
View File

@ -179,9 +179,13 @@ export class HomeUtil {
const code = authenticator.generate(secret); const code = authenticator.generate(secret);
await this.driver.find('input[name="verificationCode"]').sendKeys(code); await this.driver.find('input[name="verificationCode"]').sendKeys(code);
await this.driver.find('.test-mfa-submit').click(); await this.driver.find('.test-mfa-submit').click();
await this.driver.wait(async () => { await this.driver.wait(
return !await this.driver.findContent('.test-mfa-title', 'Almost there!').isPresent(); async () => {
}, 4000); return !await this.driver.findContent('.test-mfa-title', 'Almost there!').isPresent();
},
4000,
'Possible reason: verification code is invalid or expired (i.e. was recently used to log in)'
);
} }
/** /**