(core) Configure more comprehensive eslint rules for Typescript

Summary:
- Update rules to be more like we've had with tslint
- Switch tsserver plugin to eslint (tsserver makes for a much faster way to lint in editors)
- Apply suggested auto-fixes
- Fix all lint errors and warnings in core/, app/, test/

Test Plan: Some behavior may change subtly (e.g. added missing awaits), relying on existing tests to catch problems.

Reviewers: paulfitz

Reviewed By: paulfitz

Differential Revision: https://phab.getgrist.com/D2785

app/gen-server/lib/DocApiForwarder.ts

@@ -55,7 +55,9 @@ export class DocApiForwarder {
     app.use('^/api/docs$', withoutDoc);
   }
 
-  private async _forwardToDocWorker(withDocId: boolean, role: 'viewers'|null, req: express.Request, res: express.Response): Promise<void> {
+  private async _forwardToDocWorker(
+    withDocId: boolean, role: 'viewers'|null, req: express.Request, res: express.Response,
+  ): Promise<void> {
     let docId: string|null = null;
     if (withDocId) {
       const docAuth = await getOrSetDocAuth(req as RequestWithLogin, this._dbManager, req.params.docId);

app/gen-server/lib/DocWorkerMap.ts

@@ -424,7 +424,7 @@ export class DocWorkerMap implements IDocWorkerMap {
   }
 
   public async updateDocStatus(docId: string, checksum: string): Promise<void> {
-    this.updateChecksum('doc', docId, checksum);
+    return this.updateChecksum('doc', docId, checksum);
   }
 
   public async updateChecksum(family: string, key: string, checksum: string) {

app/gen-server/lib/HomeDBManager.ts

@@ -8,8 +8,8 @@ import {checkSubdomainValidity} from 'app/common/orgNameUtils';
 import * as roles from 'app/common/roles';
 // TODO: API should implement UserAPI
 import {ANONYMOUS_USER_EMAIL, DocumentProperties, EVERYONE_EMAIL,
-        ManagerDelta, NEW_DOCUMENT_CODE, Organization as OrgInfo,
-        OrganizationProperties, PermissionData, PermissionDelta, SUPPORT_EMAIL, UserAccessData,
+        ManagerDelta, NEW_DOCUMENT_CODE, OrganizationProperties,
+        Organization as OrgInfo, PermissionData, PermissionDelta, SUPPORT_EMAIL, UserAccessData,
         WorkspaceProperties} from "app/common/UserAPI";
 import {AclRule, AclRuleDoc, AclRuleOrg, AclRuleWs} from "app/gen-server/entity/AclRule";
 import {Alias} from "app/gen-server/entity/Alias";
@@ -1903,7 +1903,7 @@ export class HomeDBManager extends EventEmitter {
       name: u.name,
       email: u.logins.map((login: Login) => login.displayEmail)[0],
       picture: u.picture,
-      access: userRoleMap[u.id] as roles.Role
+      access: userRoleMap[u.id]
     }));
     return {
       status: 200,
@@ -2811,7 +2811,7 @@ export class HomeDBManager extends EventEmitter {
       let effectiveUserId = userId;
       let threshold = options.markPermissions;
       if (options.allowSpecialPermit && scope.specialPermit && scope.specialPermit.docId) {
-        query = query.andWhere('docs.id = :docId', {docId: scope.specialPermit.docId!});
+        query = query.andWhere('docs.id = :docId', {docId: scope.specialPermit.docId});
         effectiveUserId = this.getPreviewerUserId();
         threshold = Permissions.VIEW;
       }
@@ -3051,7 +3051,7 @@ export class HomeDBManager extends EventEmitter {
       if (!groupProps.orgOnly || !inherit) {
         // Skip this group if it's an org only group and the resource inherits from a parent.
         const group = new Group();
-        group.name = groupProps.name as roles.Role;
+        group.name = groupProps.name;
         if (inherit) {
           this._setInheritance(group, inherit);
         }
@@ -3333,7 +3333,10 @@ export class HomeDBManager extends EventEmitter {
                   `${everyoneId} IN (gu0.user_id, gu1.user_id, gu2.user_id, gu3.user_id) ` +
                   `then ${everyoneContribution} else (case when ` +
                   `${anonId} IN (gu0.user_id, gu1.user_id, gu2.user_id, gu3.user_id) ` +
-                  `then ${Permissions.PUBLIC} | acl_rules.permissions else acl_rules.permissions end) end)`, 8), 'permissions');
+                  `then ${Permissions.PUBLIC} | acl_rules.permissions else acl_rules.permissions end) end)`, 8
+            ),
+            'permissions'
+          );
         }
         q = q.from('acl_rules', 'acl_rules');
         q = this._getUsersAcls(q, users, accessStyle);

app/gen-server/lib/Housekeeper.ts

@@ -210,7 +210,9 @@ export class Housekeeper {
 
   // Call a document endpoint with a permit, cleaning up after the call.
   // Checks that the user is the support user.
-  private _withSupport(callback: (docId: string, headers: Record<string, string>) => Promise<Fetch.Response>): express.RequestHandler {
+  private _withSupport(
+    callback: (docId: string, headers: Record<string, string>) => Promise<Fetch.Response>
+  ): express.RequestHandler {
     return expressWrap(async (req, res) => {
       const userId = getAuthorizedUserId(req);
       if (userId !== this._dbManager.getSupportUserId()) {