Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2024-10-27 20:44:07 +00:00
Code Issues Projects Releases Wiki Activity

(core) Prevent stray 'compare' param from appearing in some snapshot links

Browse Source 
Summary:
Some slight difference appeared, possibly during rebase, about including
compare parameters in URLs.

Test Plan: Browser test was failing, now passes

Reviewers: paulfitz

Reviewed By: paulfitz

Differential Revision: https://phab.getgrist.com/D2683
This commit is contained in:
Dmitry S 2020-12-09 17:45:28 -05:00
parent 92224084e4
commit 4f263fc7ec
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/client/ui/DocHistory.ts
View File

@ -59,7 +59,9 @@ export class DocHistory extends Disposable implements IDomComponent {
// We include urlState().state to preserve the currently selected page. // We include urlState().state to preserve the currently selected page.
function setLink(snapshot: DocSnapshot, compareDocId?: string) { function setLink(snapshot: DocSnapshot, compareDocId?: string) {
return dom.attr('href', (use) => urlState().makeUrl({ return dom.attr('href', (use) => urlState().makeUrl({
...use(urlState().state), doc: snapshot.docId, params: {compare: compareDocId}})); ...use(urlState().state), doc: snapshot.docId,
params: (compareDocId ? {compare: compareDocId} : {})
}));
} }
const snapshots = Observable.create<DocSnapshot[]>(owner, []); const snapshots = Observable.create<DocSnapshot[]>(owner, []);