Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2026-03-02 04:09:24 +00:00
Code Issues Projects Releases Wiki Activity

(core) Just return a list from _get_col_subset, remove ColumnView class

Browse Source 
Summary: Just return a list from _get_col_subset, remove ColumnView class

Test Plan: none

Reviewers: dsagal, georgegevoian

Reviewed By: dsagal, georgegevoian

Subscribers: georgegevoian

Differential Revision: https://phab.getgrist.com/D2975
This commit is contained in:
Alex Hall
2021-08-12 02:36:59 +02:00
parent 0d1a285129
commit 4cd888c342
4 changed files with 9 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
sandbox/grist/test_renames.py
View File

@@ -226,13 +226,6 @@ class TestRenames(test_engine.EngineTestCase):
"People.lookupOne(addr=$id, city=$city).nombre",
"People.lookupRecords(addr=$id).nombre"]
}],
# TODO This is a symptom of comparing before and after values using rich values that refer
# to a destroyed column (a ColumnView). In reality, the values before and after after the
# same, but here the attempt to encode the previous value produces an incorrect result.
# (It's a bug, but not easy to fix and hopefully hard to run into.)
["BulkUpdateRecord", "Address", [11, 12, 13],
{"people2": [["L", "Sam"], ["L", "Bob", "Doug"], ["L", "Alice"]]
}],
]})
def test_rename_lookup_ref_attr(self):