(core) Focusing the creator panel on the table wiget for charts and custom views

Summary:
When a chart page/section is added and the creator panel is already open, focus is set to a "table" tab.
When a custom view is added as a page/section, the same thing happens, but there is also a behavioral tooltip shown
for the custom URL.

Test Plan: Updated and added.

Reviewers: georgegevoian

Reviewed By: georgegevoian

Differential Revision: https://phab.getgrist.com/D3857
This commit is contained in:
Jarosław Sadziński
2023-04-14 12:09:50 +02:00
parent cc0e1154d0
commit 40ea6bb2bc
11 changed files with 134 additions and 7 deletions

View File

@@ -77,6 +77,11 @@ export class BehavioralPromptsManager extends Disposable {
this._isDisabled = true;
}
public reset() {
this._prefs.set({...this._prefs.get(), dismissedTips: [], dontShowTips: false});
this.enable();
}
private _queueTip(refElement: Element, prompt: BehavioralPrompt, options: AttachOptions) {
if (
this._isDisabled ||

View File

@@ -513,6 +513,24 @@ export class GristDoc extends DisposableWithEvents {
this.draftMonitor = Drafts.create(this, this);
this.cursorMonitor = CursorMonitor.create(this, this);
this.editorMonitor = EditorMonitor.create(this, this);
// When active section is changed to a chart or custom widget, change the tab in the creator
// panel to the table.
this.autoDispose(this.viewModel.activeSection.subscribe((section) => {
if (section.isDisposed() || section._isDeleted.peek()) { return; }
if ('chart' === section.parentKey.peek()) {
commands.allCommands.viewTabFocus.run();
} else if ('custom' === section.parentKey.peek()) {
// Check if user has seen custom URL tooltip.
const seenTooltip = this.behavioralPromptsManager.hasSeenTip('customURL');
// If yes, just focus on the table if it is opened
if (seenTooltip) {
commands.allCommands.viewTabFocus.run();
} else {
commands.allCommands.viewTabOpen.run();
}
}
}));
}
/**

View File

@@ -73,6 +73,11 @@ exports.groups = [{
keys: [],
desc: 'Shortcut to open view tab'
},
{
name: 'viewTabFocus',
keys: [],
desc: 'Shortcut to focus view tab if creator panel is open'
},
{
name: 'fieldTabOpen',
keys: [],