Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2024-10-27 20:44:07 +00:00
Code Issues Projects Releases Wiki Activity

(core) FormulaEditor was updating formula when nothing has changed

Browse Source 
Summary:
FormulaEditor on sidepanel was sending update action when
formula wasn't updated by the user.

Test Plan: Existing tests

Reviewers: paulfitz

Reviewed By: paulfitz

Subscribers: paulfitz

Differential Revision: https://phab.getgrist.com/D3545
This commit is contained in:
Jarosław Sadziński 2022-07-25 11:49:35 +02:00
parent aeba738f7c
commit 364715eba3
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
app/client/widgets/FormulaEditor.ts
View File

@ -293,12 +293,17 @@ export function openFormulaEditor(options: {
// AsyncOnce ensures it's called once even if triggered multiple times.
const saveEdit = asyncOnce(async () => {
const formula = editor.getCellValue();
if (options.onSave) {
await options.onSave(column, formula as string);
} else if (formula !== column.formula.peek()) {
await column.updateColValues({formula});
if (formula !== column.formula.peek()) {
if (options.onSave) {
await options.onSave(column, formula as string);
} else {
await column.updateColValues({formula});
}
holder.dispose();
} else {
holder.dispose();
options.onCancel?.();
}
holder.dispose();
});
// These are the commands for while the editor is active.