Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2024-10-27 20:44:07 +00:00
Code Issues Projects Releases Wiki Activity

(core) Attempt to fix truncated div issues for menu popups on Safari

Browse Source 
Summary:
This affects the "Add Column" submenu under the sort-and-filter dropdown. The
explicit overflow setting (which *should* be the default) seems to fix it.

Test Plan: Tested manually on Safari 17.3 on Mac

Reviewers: georgegevoian

Reviewed By: georgegevoian

Subscribers: jarek, georgegevoian

Differential Revision: https://phab.getgrist.com/D4249
This commit is contained in:
Dmitry S 2024-05-08 19:33:51 -04:00
parent e299f4466b
commit 3267012226
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/client/ui2018/menus.ts
View File

@ -166,6 +166,7 @@ const cssSubMenuElem = styled('div', `
min-width: 200px; min-width: 200px;
`); `);
// Note: "overflow: visible" happens to matter for Safari.
export const cssMenuElem = styled('div', ` export const cssMenuElem = styled('div', `
font-family: ${vars.fontFamily}; font-family: ${vars.fontFamily};
font-size: ${vars.mediumFontSize}; font-size: ${vars.mediumFontSize};
@ -178,6 +179,7 @@ export const cssMenuElem = styled('div', `
--weaseljs-selected-background-color: ${theme.menuItemSelectedBg}; --weaseljs-selected-background-color: ${theme.menuItemSelectedBg};
--weaseljs-menu-item-padding: 8px 24px; --weaseljs-menu-item-padding: 8px 24px;
background-color: ${theme.menuBg}; background-color: ${theme.menuBg};
overflow: visible;
@media print { @media print {
& { & {