Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2024-10-27 20:44:07 +00:00
Code Issues Projects Releases Wiki Activity

(core) Preserving scroll position on Raw Data Page

Browse Source 
Summary: On Raw Data page, when there are multiple tables, the scroll position shouldn't be changed when a table is opened and closed.

Test Plan: Existing tests

Reviewers: dsagal

Subscribers: dsagal

Differential Revision: https://phab.getgrist.com/D3770
This commit is contained in:
Jarosław Sadziński 2023-01-20 14:53:29 +01:00
parent dda453714a
commit 2f39c07a5a
1 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
app/client/components/RawDataPage.ts
View File

@ -42,10 +42,12 @@ export class RawDataPage extends Disposable {
public buildDom() { public buildDom() {
return cssContainer( return cssContainer(
dom('div', this._gristDoc.behavioralPromptsManager.attachTip('rawDataPage', {hideArrow: true})), cssPage(
dom('div', dom('div', this._gristDoc.behavioralPromptsManager.attachTip('rawDataPage', {hideArrow: true})),
dom.create(DataTables, this._gristDoc), dom('div',
dom.create(DocumentUsage, this._gristDoc.docPageModel), dom.create(DataTables, this._gristDoc),
dom.create(DocumentUsage, this._gristDoc.docPageModel)
),
// We are hiding it, because overlay doesn't have a z-index (it conflicts with a searchbar and list buttons) // We are hiding it, because overlay doesn't have a z-index (it conflicts with a searchbar and list buttons)
dom.hide(this._lightboxVisible) dom.hide(this._lightboxVisible)
), ),
@ -101,8 +103,13 @@ export class RawDataPopup extends Disposable {
} }
const cssContainer = styled('div', ` const cssContainer = styled('div', `
overflow-y: auto; height: 100%;
overflow: hidden;
position: relative; position: relative;
`);
const cssPage = styled('div', `
overflow-y: auto;
height: 100%; height: 100%;
padding: 32px 64px 24px 64px; padding: 32px 64px 24px 64px;
@media ${mediaSmall} { @media ${mediaSmall} {