Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2024-10-27 20:44:07 +00:00
Code Issues Projects Releases Wiki Activity

(core) Null or undefined value on the Integer / Numeric cell

Browse Source 
Summary: Text editor for Integer and Numeric column was showing null or undefined when the underlying value was null.

Test Plan: Browser test

Reviewers: dsagal

Reviewed By: dsagal

Differential Revision: https://phab.getgrist.com/D2817
This commit is contained in:
Jarosław Sadziński 2021-05-14 20:53:36 +02:00
parent 15723d1300
commit 2c93eafa44
3 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/client/widgets/NTextEditor.ts
View File

@ -33,7 +33,7 @@ export class NTextEditor extends NewBaseEditor {
this._contentSizer = dom('div.celleditor_content_measure'),
this.textInput = dom('textarea', dom.cls('celleditor_text_editor'),
dom.style('text-align', this._alignment),
dom.prop('value', undefDefault(options.editValue, String(options.cellValue))),
dom.prop('value', undefDefault(options.editValue, String(options.cellValue ?? ""))),
this.commandGroup.attach(),
// Resize the textbox whenever user types in it.
dom.on('input', () => this.resizeInput())

2
app/client/widgets/TextEditor.js
View File

@ -39,7 +39,7 @@ function TextEditor(options) {
this.textInput = dom('textarea.celleditor_text_editor',
kd.attr('placeholder', options.placeholder || ''),
kd.style('text-align', this._alignment),
kd.value(gutil.undefDefault(options.editValue, String(options.cellValue))),
kd.value(gutil.undefDefault(options.editValue, String(options.cellValue == null ? "" : options.cellValue))),
this.commandGroup.attach(),
// Resize the textbox whenever user types in it.

14
test/nbrowser/gristUtils.ts
View File

@ -1422,6 +1422,20 @@ export function hexToRgb(hex: string) {
return `rgba(${r}, ${g}, ${b}, 1)`;
}
/**
* Adds new column to the table.
* @param name Name of the column
*/
export async function addColumn(name: string) {
await scrollIntoView(await driver.find('.active_section .mod-add-column'));
await driver.find('.active_section .mod-add-column').click();
await waitForServer();
await waitAppFocus(false);
await driver.sendKeys(name);
await driver.sendKeys(Key.ENTER);
await waitForServer();
}
} // end of namespace gristUtils