Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2024-10-27 20:44:07 +00:00
Code Issues Projects Releases Wiki Activity

(core) Fixing dispose bug on GridView

Browse Source 
Summary:
When disposing a GridView (i.e. switching pages) there was JS error. It was caused, by
autodisposing knockout observable.

Test Plan: manual tests

Reviewers: georgegevoian

Reviewed By: georgegevoian

Differential Revision: https://phab.getgrist.com/D3201
This commit is contained in:
Jarosław Sadziński 2021-12-29 21:46:27 +01:00
parent 0482c83771
commit 24c57e05d7
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/client/components/GridView.js
View File

@ -190,7 +190,7 @@ function GridView(gristDoc, viewSectionModel, isPreview = false) {
}, this)); }, this));
// Holds column index that is hovered, works only in full-edit formula mode. // Holds column index that is hovered, works only in full-edit formula mode.
this.hoverColumn = this.autoDispose(ko.observable(-1)); this.hoverColumn = ko.observable(-1);
// Debounced method to change current hover column, this is needed // Debounced method to change current hover column, this is needed
// as mouse when moved from field to field will switch the hover-column // as mouse when moved from field to field will switch the hover-column
// observable from current index to -1 and then immediately back to current index. // observable from current index to -1 and then immediately back to current index.