Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2025-06-13 20:53:59 +00:00
Code Issues Projects Releases Wiki Activity

(core) Remove 'new' from IDocPage

Browse Source 
Summary: The value seems unused

Test Plan: This is me testing if it's actually unused

Reviewers: dsagal

Reviewed By: dsagal

Differential Revision: https://phab.getgrist.com/D3244
This commit is contained in:
Alex Hall 2022-02-03 17:08:25 +02:00
parent fa9e6eee88
commit 22006754af
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/client/components/GristDoc.ts
View File

@ -350,7 +350,7 @@ export class GristDoc extends DisposableWithEvents {
dom.domComputed<IDocPage>(this.activeViewId, (viewId) => ( dom.domComputed<IDocPage>(this.activeViewId, (viewId) => (
viewId === 'code' ? dom.create((owner) => owner.autoDispose(CodeEditorPanel.create(this))) : viewId === 'code' ? dom.create((owner) => owner.autoDispose(CodeEditorPanel.create(this))) :
viewId === 'acl' ? dom.create((owner) => owner.autoDispose(AccessRules.create(this, this))) : viewId === 'acl' ? dom.create((owner) => owner.autoDispose(AccessRules.create(this, this))) :
viewId === 'new' || viewId == 'GristDocTour' ? null : viewId === 'GristDocTour' ? null :
dom.create((owner) => (this._viewLayout = ViewLayout.create(owner, this, viewId))) dom.create((owner) => (this._viewLayout = ViewLayout.create(owner, this, viewId)))
)), )),
); );

6
app/common/gristUrls.ts
View File

@ -10,7 +10,7 @@ import {Document} from 'app/common/UserAPI';
import clone = require('lodash/clone'); import clone = require('lodash/clone');
import pickBy = require('lodash/pickBy'); import pickBy = require('lodash/pickBy');
export type IDocPage = number | 'new' | 'code' | 'acl' | 'GristDocTour'; export type IDocPage = number | 'code' | 'acl' | 'GristDocTour';
// What page to show in the user's home area. Defaults to 'workspace' if a workspace is set, and // What page to show in the user's home area. Defaults to 'workspace' if a workspace is set, and
// to 'all' otherwise. // to 'all' otherwise.
@ -356,8 +356,8 @@ export function userOverrideParams(email: string|null, extraState?: IGristUrlSta
* parseDocPage is a noop if p is 'new' or 'code', otherwise parse to integer * parseDocPage is a noop if p is 'new' or 'code', otherwise parse to integer
*/ */
function parseDocPage(p: string) { function parseDocPage(p: string) {
if (['new', 'code', 'acl', 'GristDocTour'].includes(p)) { if (['code', 'acl', 'GristDocTour'].includes(p)) {
return p as 'new'|'code'|'acl'|'GristDocTour'; return p as 'code'|'acl'|'GristDocTour';
} }
return parseInt(p, 10); return parseInt(p, 10);
} }