Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2024-10-27 20:44:07 +00:00
Code Issues Projects Releases Wiki Activity

remove old comment that gvisor is not available in grist-core (#295)

Browse Source 
Removes a comment now that `gvisor` works fine with grist-core, and is packaged in the docker image. Reorders possible sandbox flavors to de-emphasize `pynbox` since it isn't packaged in the docker image.
This commit is contained in:
Paul Fitzpatrick 2022-09-28 17:29:32 -04:00 committed by GitHub
parent 49b1749e98
commit 20f935367b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/server/lib/NSandbox.ts
View File

@ -382,8 +382,8 @@ function isFlavor(flavor: string): flavor is keyof typeof spawners {
* grist-core), and trying to regularize creation options a bit. * grist-core), and trying to regularize creation options a bit.
* *
* The flavor of sandbox to use can be overridden by some environment variables: * The flavor of sandbox to use can be overridden by some environment variables:
* - GRIST_SANDBOX_FLAVOR: should be one of the spawners (pynbox, unsandboxed, docker, * - GRIST_SANDBOX_FLAVOR: should be one of the spawners (gvisor, unsandboxed, docker,
* gvisor, macSandboxExec) * macSandboxExec, pynbox)
* - GRIST_SANDBOX: a program or image name to run as the sandbox. Not needed for * - GRIST_SANDBOX: a program or image name to run as the sandbox. Not needed for
* pynbox (it is either built in or not available). For unsandboxed, should be an * pynbox (it is either built in or not available). For unsandboxed, should be an
* absolute path to python within a virtualenv with all requirements installed. * absolute path to python within a virtualenv with all requirements installed.
@ -391,7 +391,7 @@ function isFlavor(flavor: string): flavor is keyof typeof spawners {
* in `sandbox/docker`) or a derived image. For gvisor, it should be the full path * in `sandbox/docker`) or a derived image. For gvisor, it should be the full path
* to `sandbox/gvisor/run.py` (if runsc available locally) or to * to `sandbox/gvisor/run.py` (if runsc available locally) or to
* `sandbox/gvisor/wrap_in_docker.sh` (if runsc should be run using the docker * `sandbox/gvisor/wrap_in_docker.sh` (if runsc should be run using the docker
* image built in that directory). Gvisor is not yet available in grist-core. * image built in that directory).
* - PYTHON_VERSION: for gvisor, this is mandatory, and must be set to "2" or "3". * - PYTHON_VERSION: for gvisor, this is mandatory, and must be set to "2" or "3".
* It is ignored by other flavors. * It is ignored by other flavors.
*/ */