Improve input team member (#268)

* Autocomplete for email
* Remove old MemberEmail input and styled correctly the new autocomplete one
* Add validation on autocomplete input
* fix selected item styling
* Add prompt feature on ACUserManager
* Add sort for result in autocomplete
* Add attach option to autocomplete

Co-authored-by: Ronan Amicel <ronan.amicel.prestataire@anct.gouv.fr>

app/client/lib/ACSelect.ts

@@ -100,7 +100,7 @@ const cssSelectBtn = styled('div', `
   --icon-color: ${theme.selectButtonFg};
 `);
 
-const cssSelectItem = styled('li', `
+export const cssSelectItem = styled('li', `
   color: ${theme.menuItemFg};
   display: block;
   white-space: pre;

app/client/lib/ACUserManager.ts

@@ -0,0 +1,204 @@
+import {ACResults, ACIndex, ACItem, buildHighlightedDom, normalizeText} from "app/client/lib/ACIndex";
+import {cssSelectItem} from "app/client/lib/ACSelect";
+import {Autocomplete, IAutocompleteOptions} from "app/client/lib/autocomplete";
+import {cssMenuItem} from "popweasel";
+
+import {testId, colors, theme} from "app/client/ui2018/cssVars";
+import {menuCssClass} from "app/client/ui2018/menus";
+import {dom, DomElementArg, Holder, IDisposableOwner, Observable, styled, computed, Computed} from "grainjs";
+import {
+  cssEmailInput,
+  cssEmailInputContainer,
+  cssMailIcon,
+  cssMemberImage,
+  cssMemberListItem,
+  cssMemberPrimary,
+  cssMemberSecondary,
+  cssMemberText,
+} from "app/client/ui/UserItem";
+import {createUserImage, cssUserImage} from "app/client/ui/UserImage";
+
+export interface ACUserItem extends ACItem {
+  value: string;
+  label: string;
+  name: string;
+  email: string;
+  id: number;
+  picture?: string | null; // when present, a url to a public image of unspecified dimensions.
+  isNew?: boolean;
+}
+
+export function buildACMemberEmail(
+  owner: IDisposableOwner,
+  options: {
+    acIndex: ACIndex<ACUserItem>;
+    emailObs: Observable<string>;
+    save: (value: string) => Promise<void> | void;
+    isInputValid: Observable<boolean>;
+    prompt?: {email: string},
+  },
+  ...args: DomElementArg[]
+) {
+  const { acIndex, emailObs, save, isInputValid, prompt } = options;
+  const acHolder = Holder.create<Autocomplete<ACUserItem>>(owner);
+  let emailInput: HTMLInputElement;
+
+  const isOpen = () => !acHolder.isEmpty();
+  const acOpen = () => acHolder.isEmpty() && Autocomplete.create(acHolder, emailInput, acOptions);
+  const acClose = () => acHolder.clear();
+  const finish = () => {
+    acClose();
+    emailObs.set("");
+    emailInput.value = emailObs.get();
+    emailInput.focus();
+  };
+  const openOrCommit = () => {
+    isOpen() ? commitIfValid() : acOpen();
+  };
+
+  const commitIfValid = () => {
+    const item = acHolder.get()?.getSelectedItem();
+    if (item) {
+      emailObs.set(item.value);
+    }
+    emailInput.setCustomValidity("");
+    const selectedEmail = item?.value || emailObs.get();
+    try {
+      if (selectedEmail && isInputValid.get()) {
+        save(emailObs.get());
+        finish();
+      }
+    } catch (e) {
+        emailInput.setCustomValidity(e.message);
+    } finally {
+      emailInput.reportValidity();
+    }
+  };
+
+  const maybeShowAddNew = async (results: ACResults<ACUserItem>, text: string): Promise<ACResults<ACUserItem>> => {
+    const cleanText = normalizeText(text);
+    const items = results.items
+      .filter(item => item.cleanText.includes(cleanText))
+      .sort((a,b) => a.cleanText.localeCompare(b.cleanText));
+    results.items = items;
+    if (!results.items.length) {
+      const newObject = {
+        value: text,
+        cleanText,
+        name: "",
+        email: "",
+        isNew: true,
+        label: text,
+        id: 0,
+      };
+      results.items.push(newObject);
+    }
+    return results;
+  };
+
+  const renderSearchItem = (item: ACUserItem, highlightFunc: any): HTMLLIElement => (item?.isNew ? cssSelectItem(
+    cssMemberListItem(
+      cssUserImagePlus(
+        "+",
+        cssUserImage.cls("-large"),
+        cssUserImagePlus.cls('-invalid', (use) => !use(enableAdd),
+      )),
+      cssMemberText(
+        cssMemberPrimaryPlus("Invite new member"),
+        cssMemberSecondaryPlus(
+          dom.text(use => `We'll email an invite to ${use(emailObs)}`)
+        )
+      ),
+      testId("um-add-email")
+    )
+  ) : cssSelectItem(
+    cssMemberListItem(
+      cssMemberImage(createUserImage(item, "large")),
+      cssMemberText(
+        cssMemberPrimaryPlus(item.name, testId("um-member-name")),
+        cssMemberSecondaryPlus(buildHighlightedDom(item.label, highlightFunc, cssMatchText))
+      )
+    )
+  ));
+
+  const enableAdd: Computed<boolean> = computed((use) => Boolean(use(emailObs) && use(isInputValid)));
+
+  const acOptions: IAutocompleteOptions<ACUserItem> = {
+    attach: null,
+    menuCssClass: `${menuCssClass} test-acselect-dropdown`,
+    search: (term) => maybeShowAddNew(acIndex.search(term), term),
+    renderItem: renderSearchItem,
+    getItemText: (item) => item.value,
+    onClick: commitIfValid,
+  };
+
+  const result = cssEmailInputContainer(
+    cssMailIcon("Mail"),
+    (emailInput = cssEmailInput(
+      emailObs,
+      {onInput: true, isValid: isInputValid},
+      {type: "email", placeholder: "Enter email address"},
+      dom.on("input", acOpen),
+      dom.on("focus", acOpen),
+      dom.on("click", acOpen),
+      dom.on("blur", acClose),
+      dom.onKeyDown({
+        Escape: finish,
+        Enter: openOrCommit,
+        ArrowDown: acOpen,
+        Tab: commitIfValid,
+      }),
+      ...args
+      )),
+    cssEmailInputContainer.cls('-green', enableAdd),
+  );
+
+  if (prompt) { setTimeout(() => emailInput.focus(), 0); }
+
+  return result;
+}
+
+const cssMemberPrimaryPlus = styled(
+  cssMemberPrimary,
+  `
+  .${cssSelectItem.className}.selected & {
+    color: ${theme.menuItemSelectedFg};
+  }
+`
+);
+
+const cssMemberSecondaryPlus = styled(
+  cssMemberSecondary,
+  `
+  .${cssSelectItem.className}.selected & {
+    color: ${theme.menuItemSelectedFg};
+  }
+`
+);
+
+const cssMatchText = styled(
+  "span",
+  `
+  color: ${theme.autocompleteMatchText};
+  .${cssSelectItem.className}.selected & {
+    color: ${theme.autocompleteSelectedMatchText};
+  }
+`
+);
+
+const cssUserImagePlus = styled(
+  cssUserImage,
+  `
+  background-color: ${colors.lightGreen};
+  margin: auto 0;
+
+  &-invalid {
+    background-color: ${colors.mediumGrey};
+  }
+
+  .${cssMenuItem.className}-sel & {
+    background-color: ${theme.menuItemIconSelectedFg};
+    color: ${theme.menuItemSelectedBg};
+  }
+`
+);

app/client/lib/autocomplete.ts

@@ -32,6 +32,10 @@ export interface IAutocompleteOptions<Item extends ACItem> {
 
   // A callback triggered when user clicks one of the choices.
   onClick?(): void;
+
+  // To which element to append the popup content. Null means triggerElem.parentNode and is the
+  // default; string is a selector for the closest matching ancestor of triggerElem, e.g. 'body'.
+  attach?: Element|string|null;
 }
 
 /**
@@ -86,8 +90,10 @@ export class Autocomplete<Item extends ACItem> extends Disposable {
     this.search();
     this.autoDispose(dom.onElem(_triggerElem, 'input', () => this.search()));
 
-    // Attach the content to the page.
-    document.body.appendChild(content);
+    const attachElem = _options.attach === undefined ? document.body : _options.attach;
+    const containerElem = getContainer(_triggerElem, attachElem) ?? document.body;
+    containerElem.appendChild(content);
+
     this.onDispose(() => { dom.domDispose(content); content.remove(); });
 
     // Prepare and create the Popper instance, which places the content according to the options.
@@ -198,6 +204,15 @@ export const defaultPopperOptions: Partial<PopperOptions> = {
 };
 
 
+/**
+ * Helper that finds the container according to attachElem. Null means
+ * elem.parentNode; string is a selector for the closest matching ancestor, e.g. 'body'.
+ */
+ function getContainer(elem: Element, attachElem: Element|string|null): Node|null {
+  return (typeof attachElem === 'string') ? elem.closest(attachElem) :
+    (attachElem || elem.parentNode);
+}
+
 /**
  * Helper function which returns the direct child of ancestor which is an ancestor of elem, or
  * null if elem is not a descendant of ancestor.