mirror of
https://github.com/gristlabs/grist-core.git
synced 2026-03-02 04:09:24 +00:00
(core) Enabling telemetry on /api/version endpoint
Summary: Version API endpoint wasn't logging telemetry from POST requests. The issue was in registration order, this endpoint was registered before `expressJson` and it couldn't read json body in the handler. Test Plan: Added new test Reviewers: paulfitz Reviewed By: paulfitz Subscribers: paulfitz Differential Revision: https://phab.getgrist.com/D4277
This commit is contained in:
@@ -102,16 +102,6 @@ describe('Comm', function() {
|
||||
}
|
||||
};
|
||||
|
||||
beforeEach(function() {
|
||||
// Silence console messages from client-side Comm.ts.
|
||||
if (!process.env.VERBOSE) {
|
||||
// TODO: This no longer works, now that 'log' is a more proper "module" object rather than
|
||||
// an arbitrary JS object. Also used in a couple other tests where logs are no longer
|
||||
// silenced.
|
||||
sandbox.stub(log, 'debug');
|
||||
}
|
||||
});
|
||||
|
||||
afterEach(async function() {
|
||||
// Run the cleanup callbacks registered in cleanup().
|
||||
await Promise.all(cleanup.splice(0).map(callback => callback()));
|
||||
|
||||
@@ -4029,7 +4029,7 @@ function testDocApi() {
|
||||
...pick(options, 'name', 'memo', 'enabled', 'watchedColIds'),
|
||||
}, chimpy
|
||||
);
|
||||
assert.equal(status, 200);
|
||||
assert.equal(status, 200, `Error during subscription: ` + JSON.stringify(data));
|
||||
return data as WebhookSubscription;
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user