Add tests for UsersManager (#1149)

Browse Source

Context

HomeDBManager lacks of direct tests, which makes hard to make rework or refactorations.
Proposed solution

Specifically here, I introduce tests which call exposed UsersManager methods directly and check their result.

Also:

    I removed updateUserName which seems to me useless (updateUser does the same work)
    Taking a look at the getUserByLogin methods, it appears that Typescirpt infers it returns a Promise<User|null> while in no case it may resolve a nullish value, therefore I have forced to return a Promise<User> and have changed the call sites to reflect the change.

Related issues

I make this change for then working on #870

...

This commit is contained in:

Florent

2024-09-05 22:30:04 +02:00

committed by GitHub

parent 356f0b423e

commit 16ebc32611

21 changed files with 1217 additions and 169 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

1033

test/gen-server/lib/homedb/UsersManager.ts Normal file

File diff suppressed because it is too large Load Diff