Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2024-10-27 20:44:07 +00:00
Code Issues Projects Releases Wiki Activity

(core) Upgrade friendly-traceback and its dependencies

Browse Source 
Summary:
Upgrading the friendly-traceback package to include a fix that I specifically requested in https://github.com/friendly-traceback/friendly-traceback/issues/144 as a solution for the problem mentioned in https://grist.quip.com/HoSmAlvFax0j#MbTADAEcJb7 . Specifically, this shows a friendly explanation when using `len()` with a generator expression.

Also upgraded the dependencies `executing` and `stack_data` (which are mine) while I'm at it, although I don't expect this to really change anything.

Test Plan:
Existing tests. There was one test failure because of a new explanation about generic `Exception`s which I've suppressed.

Tested manually that the new explanation appears:

{F64605}

Reviewers: dsagal

Reviewed By: dsagal

Differential Revision: https://phab.getgrist.com/D3687
This commit is contained in:
Alex Hall 2022-10-27 17:38:41 +02:00
parent d81bba625a
commit 16a43edc2e
2 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
sandbox/grist/friendly_errors.py
View File

@ -24,6 +24,10 @@ def friendly_message(exc):
# with a suggestion to report the case on GitHub. # with a suggestion to report the case on GitHub.
return "" return ""
if "All built-in exceptions defined by Python are derived from `Exception`" in generic:
# Unhelpful explanation for a generic `Exception`
return ""
# Add a blank line between the standard message and the friendly message # Add a blank line between the standard message and the friendly message
result = "\n\n" + generic result = "\n\n" + generic

6
sandbox/requirements3.txt
View File

@ -1,9 +1,9 @@
### python 3 requirements, see requirements.txt for python 2 ### python 3 requirements, see requirements.txt for python 2
# friendly-traceback and its dependencies, for python 3 only # friendly-traceback and its dependencies, for python 3 only
friendly-traceback==0.5.46 friendly-traceback==0.7.48
stack-data==0.3.0 stack-data==0.5.1
executing==0.8.3 executing==1.1.1
pure-eval==0.2.2 pure-eval==0.2.2
# openpyxl and its dependencies, for imports, which are python 3 only # openpyxl and its dependencies, for imports, which are python 3 only