Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2024-10-27 20:44:07 +00:00
Code Issues Projects Releases Wiki Activity

(core) Autocomplete True/False/None in formulas from lowercase values

Browse Source 
Test Plan: Added check for these values in a relevant test case.

Reviewers: paulfitz

Reviewed By: paulfitz

Differential Revision: https://phab.getgrist.com/D3117
This commit is contained in:
Dmitry S 2021-11-04 15:02:23 -04:00
parent 58880d4818
commit 1178d35237
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
sandbox/grist/autocomplete_context.py
View File

@ -4,10 +4,9 @@ Helper class for handling formula autocomplete.
It's intended to use with rlcompleter.Completer. It allows finding global names using It's intended to use with rlcompleter.Completer. It allows finding global names using
lowercase searches, and adds function usage information to some results. lowercase searches, and adds function usage information to some results.
""" """
from six.moves import builtins
import inspect import inspect
from collections import namedtuple from collections import namedtuple
from six.moves import builtins
import six import six
# funcname is the function name, e.g. "MAX" # funcname is the function name, e.g. "MAX"
@ -31,6 +30,13 @@ class AutocompleteContext(object):
if not (value and callable(value) and getattr(value, 'unimplemented', None)) if not (value and callable(value) and getattr(value, 'unimplemented', None))
} }
# Add some common non-lowercase builtins, so that we include them into the case-handling below.
self._context.update({
'True': True,
'False': False,
'None': None,
})
# Prepare detailed Completion objects for functions where we can supply more info. # Prepare detailed Completion objects for functions where we can supply more info.
# TODO It would be nice to include builtin functions too, but getargspec doesn't work there. # TODO It would be nice to include builtin functions too, but getargspec doesn't work there.
self._functions = {} self._functions = {}
@ -51,7 +57,7 @@ class AutocompleteContext(object):
lower = key.lower() lower = key.lower()
if lower == key: if lower == key:
continue continue
if lower not in self._context and lower not in builtins.__dict__: if not any((lower in d) for d in (self._context, self._lowercase, builtins.__dict__)):
self._lowercase[lower] = key self._lowercase[lower] = key
else: else:
# This is still good enough to find a match for, and translate back to the original. # This is still good enough to find a match for, and translate back to the original.