Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2024-10-27 20:44:07 +00:00
Code Issues Projects Releases Wiki Activity

(core) don't garble document url in SELF_HYPERLINK on forks

Browse Source 
Summary: There was a bad regex processing the document url passed to the sandbox.

Test Plan: added test

Reviewers: dsagal

Reviewed By: dsagal

Differential Revision: https://phab.getgrist.com/D3048
This commit is contained in:
Paul Fitzpatrick 2021-09-28 14:46:19 -04:00
parent 8c1f8bc9a6
commit 0fffe918c1
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/server/lib/NSandbox.ts
View File

@ -582,9 +582,9 @@ function docker(options: ISandboxOptions): ChildProcess {
/** /**
* Collect environment variables that should end up set within the sandbox. * Collect environment variables that should end up set within the sandbox.
*/ */
function getInsertedEnv(options: ISandboxOptions) { export function getInsertedEnv(options: ISandboxOptions) {
const env: NodeJS.ProcessEnv = { const env: NodeJS.ProcessEnv = {
DOC_URL: (options.docUrl || '').replace(/[^-a-zA-Z0-9_:/?&.]/, ''), DOC_URL: (options.docUrl || '').replace(/[^-a-zA-Z0-9_:/?&.~]/g, ''),
// use stdin/stdout/stderr only. // use stdin/stdout/stderr only.
PIPE_MODE: options.minimalPipeMode ? 'minimal' : 'classic', PIPE_MODE: options.minimalPipeMode ? 'minimal' : 'classic',