Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2025-06-13 20:53:59 +00:00
Code Issues Projects Releases Wiki Activity

tests: detection of save copy button

Browse Source 
TODO onboarding popup

TODO better waiting for url change
This commit is contained in:
Grégoire Cutzach 2024-10-07 18:32:39 +02:00
parent 2f2f50488f
commit 09718b1219
No known key found for this signature in database
GPG Key ID: AA4155BE23C375E6
1 changed files with 31 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
test/nbrowser/DocTypeConversion.ts
View File

@ -1,9 +1,17 @@
import { UserAPI } from "app/common/UserAPI"; import { UserAPI } from "app/common/UserAPI";
//import { assert, By, driver, until } from "mocha-webdriver"; //import { assert, By, driver, until } from "mocha-webdriver";
import { assert, driver } from "mocha-webdriver"; import { assert, driver, WebElementPromise } from "mocha-webdriver";
import * as gu from "test/nbrowser/gristUtils"; import * as gu from "test/nbrowser/gristUtils";
import { setupTestSuite } from "test/nbrowser/testUtils"; import { setupTestSuite } from "test/nbrowser/testUtils";
interface Button {
click(): Promise<void>;
element(): WebElementPromise;
wait(): Promise<void>;
visible(): Promise<boolean>;
present(): Promise<boolean>;
}
describe("Document Type Conversion", function () { describe("Document Type Conversion", function () {
this.timeout(20000); this.timeout(20000);
const cleanup = setupTestSuite(); const cleanup = setupTestSuite();
@ -18,11 +26,11 @@ describe("Document Type Conversion", function () {
userApi = session.createHomeApi(); userApi = session.createHomeApi();
}); });
async function assertExists() { async function assertExistsButton(button: Button, text: String) {
await gu.waitToPass(async () => { await gu.waitToPass(async () => {
assert.equal(await editButton.element().getText(), "Edit"); assert.equal(await button.element().getText(), text);
}); });
assert.isTrue(await editButton.visible()); assert.isTrue(await button.visible());
} }
async function convert(from: String, to: String) { async function convert(from: String, to: String) {
@ -67,7 +75,7 @@ describe("Document Type Conversion", function () {
it("should allow to convert from a document type to another", async function () { it("should allow to convert from a document type to another", async function () {
await gu.openDocumentSettings(); await gu.openDocumentSettings();
// Make sure we see the Edit button of document type conversion. // Make sure we see the Edit button of document type conversion.
await assertExists(); await assertExistsButton(editButton, "Edit");
// Check that Document type is Regular before any conversion was ever apply to It. // Check that Document type is Regular before any conversion was ever apply to It.
assert.equal(await displayedLabel.element().getText(), "Regular"); assert.equal(await displayedLabel.element().getText(), "Regular");
@ -95,26 +103,40 @@ describe("Document Type Conversion", function () {
// If the next six tests succeed so each document type can properly be converted to every other // If the next six tests succeed so each document type can properly be converted to every other
it('should convert from Regular to Template', async function() { it('should convert from Regular to Template', async function() {
await convert("Regular", "Template"); await convert("Regular", "Template");
await assertExistsButton(saveCopyButton, "Save Copy");
}); });
it('should convert from Template to Tutorial', async function() { it('should convert from Template to Tutorial', async function() {
await convert("Template", "Tutorial"); await convert("Template", "Tutorial");
await assertExistsButton(saveCopyButton, "Save Copy");
await session.loadDoc(`/doc/${docId}`);
await driver.sleep(500);
assert.isTrue(await tutorialPopin.visible());
await gu.openDocumentSettings();
}); });
it('should convert from Tutorial to Regular', async function() { it('should convert from Tutorial to Regular', async function() {
await convert("Tutorial", "Regular"); await convert("Tutorial", "Regular");
assert.isFalse(await saveCopyButton.present());
}); });
it('should convert from Regular to Tutorial', async function() { it('should convert from Regular to Tutorial', async function() {
await convert("Regular", "Tutorial"); await convert("Regular", "Tutorial");
await assertExistsButton(saveCopyButton, "Save Copy");
assert.isTrue(await tutorialPopin.visible());
await session.loadDoc(`/doc/${docId}`);
await driver.sleep(500);
await gu.openDocumentSettings();
}); });
it('should convert from Tutorial to Template', async function() { it('should convert from Tutorial to Template', async function() {
await convert("Tutorial", "Template"); await convert("Tutorial", "Template");
await assertExistsButton(saveCopyButton, "Save Copy");
}); });
it('should convert from Template to Regular', async function() { it('should convert from Template to Regular', async function() {
await convert("Template", "Regular"); await convert("Template", "Regular");
assert.equal(await saveCopyButton.present(), false);
}); });
it('should be disabled for non-owners', async function() { it('should be disabled for non-owners', async function() {
@ -182,10 +204,12 @@ const option = (testId: string) => ({
}); });
const editButton = button('.test-settings-doctype-edit'); const editButton = button('.test-settings-doctype-edit');
const displayedLabel = label(".test-settings-doctype-value"); const saveCopyButton = button('.test-tb-share-action');
const modal = element(".test-settings-doctype-modal"); const displayedLabel = label('.test-settings-doctype-value');
const modal = element('.test-settings-doctype-modal');
const optionRegular = option('.test-settings-doctype-modal-option-regular'); const optionRegular = option('.test-settings-doctype-modal-option-regular');
const optionTemplate = option('.test-settings-doctype-modal-option-template'); const optionTemplate = option('.test-settings-doctype-modal-option-template');
const optionTutorial = option('.test-settings-doctype-modal-option-tutorial'); const optionTutorial = option('.test-settings-doctype-modal-option-tutorial');
const modalConfirm = button('.test-settings-doctype-modal-confirm'); const modalConfirm = button('.test-settings-doctype-modal-confirm');
const modalCancel = button('.test-settings-doctype-modal-cancel'); const modalCancel = button('.test-settings-doctype-modal-cancel');
const tutorialPopin = element('.test-onboarding-popup');