Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2026-03-02 04:09:24 +00:00
Code Issues Projects Releases Wiki Activity

(core) Tests and bug fixes for bidirectional linking

Browse Source 
Summary:
- Adding tests for bidirectional linking
- Fixing loop bug for bidirectional linking in custom widgets which use row filtering

Test Plan: New tests

Reviewers: JakubSerafin

Reviewed By: JakubSerafin

Differential Revision: https://phab.getgrist.com/D4070
This commit is contained in:
Jarosław Sadziński
2023-10-10 14:54:50 +02:00
parent a8e0f96813
commit 083a20417e
7 changed files with 439 additions and 80 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/client/components/LinkingState.ts
View File

@@ -286,7 +286,7 @@ export class LinkingState extends Disposable {
// Get previous linkingstate's info, if applicable (2 or more hops back)
const prevLink = this._srcSection.linkingState?.();
const prevLinkHasCursor = prevLink &&
const prevLinkHasCursor = prevLink?.incomingCursorPos &&
(prevLink.linkTypeDescription() === "Cursor:Same-Table" ||
prevLink.linkTypeDescription() === "Cursor:Reference");
const [prevLinkedPos, prevLinkedVersion] = prevLinkHasCursor ? prevLink.incomingCursorPos() :