fix: after lsebille review

This commit is contained in:
Grégoire Cutzach 2024-08-29 12:11:44 +02:00
parent 0d3a3b5d19
commit 06e308e8ed
No known key found for this signature in database
GPG Key ID: AA4155BE23C375E6
3 changed files with 9 additions and 8 deletions

View File

@ -106,7 +106,7 @@ const cssItem = styled('div', `
const cssItemShort = styled('div', ` const cssItemShort = styled('div', `
display: flex; display: flex;
flex-wrap: wrap; flex-wrap: nowrap;
align-items: center; align-items: center;
padding: 8px; padding: 8px;
margin: 0 -8px; margin: 0 -8px;
@ -131,7 +131,7 @@ const cssItemShort = styled('div', `
`); `);
const cssItemName = styled('div', ` const cssItemName = styled('div', `
width: 150px; width: 230px;
font-weight: bold; font-weight: bold;
display: flex; display: flex;
align-items: center; align-items: center;
@ -159,7 +159,7 @@ const cssItemName = styled('div', `
`); `);
const cssItemDescription = styled('div', ` const cssItemDescription = styled('div', `
max-width: 320px; max-width: 250px;
margin-right: auto; margin-right: auto;
margin-bottom: -1px; /* aligns with the value */ margin-bottom: -1px; /* aligns with the value */
`); `);

View File

@ -350,7 +350,7 @@ export class DocSettingsPage extends Disposable {
dom('strong', t('Regular document')), dom('strong', t('Regular document')),
), ),
dom('div', dom('div',
dom.style('margin-top', '16px'), dom.style('margin-top', '8px'),
dom('span', t('Regular document behavior, all users work on the same copy of the document.')) dom('span', t('Regular document behavior, all users work on the same copy of the document.'))
), ),
testId('doctype-modal-option-regular'), testId('doctype-modal-option-regular'),
@ -360,7 +360,7 @@ export class DocSettingsPage extends Disposable {
dom('strong', t('Template')), dom('strong', t('Template')),
), ),
dom('div', dom('div',
dom.style('margin-top', '16px'), dom.style('margin-top', '8px'),
dom('span', dom('span',
t('Document automatically opens in {{fiddleModeDocUrl}}. ' + t('Document automatically opens in {{fiddleModeDocUrl}}. ' +
'Any edit (open to anybody) will create a new unsaved copy.', 'Any edit (open to anybody) will create a new unsaved copy.',
@ -377,7 +377,7 @@ export class DocSettingsPage extends Disposable {
dom('strong', t('Tutorial')), dom('strong', t('Tutorial')),
), ),
dom('div', dom('div',
dom.style('margin-top', '16px'), dom.style('margin-top', '8px'),
dom('span', t('Document automatically opens with a new copy.')), dom('span', t('Document automatically opens with a new copy.')),
), ),
testId('doctype-modal-option-tutorial'), testId('doctype-modal-option-tutorial'),
@ -678,6 +678,7 @@ const cssAdminSection = styled(AdminSection, `
const cssDocTypeContainer = styled('div', ` const cssDocTypeContainer = styled('div', `
display: flex; display: flex;
width: 172px; width: 172px;
align-items: center;
justify-content: space-between; justify-content: space-between;
& > * { & > * {
display: inline-block; display: inline-block;

View File

@ -108,7 +108,7 @@ export const cssCheckboxCircle = styled(cssCheckboxSquare, `
`); `);
export const cssLabelText = styled('span', ` export const cssLabelText = styled('span', `
margin-left: 8px; margin-left: 16px;
color: ${theme.text}; color: ${theme.text};
font-weight: initial; /* negate bootstrap */ font-weight: initial; /* negate bootstrap */
overflow: hidden; overflow: hidden;
@ -215,7 +215,7 @@ export function toggle(value: Observable<boolean|null>, ...domArgs: DomElementAr
// checkbox doesn't support two-way binding. // checkbox doesn't support two-way binding.
const cssBlockCheckbox = styled('div', ` const cssBlockCheckbox = styled('div', `
display: flex; display: flex;
padding: 10px 8px; padding: 16px;
border: 1px solid ${theme.controlSecondaryDisabledFg}; border: 1px solid ${theme.controlSecondaryDisabledFg};
border-radius: 3px; border-radius: 3px;
cursor: pointer; cursor: pointer;