mirror of
https://github.com/gristlabs/grist-core.git
synced 2026-03-02 04:09:24 +00:00
(core) Fix filtering of empty reflists
Summary: A formula returning an empty RecordSet in a RefList columns results in storing [] instead of null. This caused a bug where the empty list was 'flattened' and the cell not appearing in filters at all. This diff fixes the bug by filtering for the default value `null` instead for RefLists and the empty string for ChoiceLists. I didn't manage to actually reproduce the bug for ChoiceLists, but this seemed the most sensible thing to do. Test Plan: New nbrowser test. Reviewers: georgegevoian Reviewed By: georgegevoian Differential Revision: https://phab.getgrist.com/D3478
This commit is contained in:
@@ -319,8 +319,13 @@ BaseView.prototype.filterByThisCellValue = function() {
|
||||
// ChoiceList and Reflist values get 'flattened' out so we filter by each element within.
|
||||
// In any other column type, complex values (even lists) get converted to JSON.
|
||||
let filterValues;
|
||||
if (gristTypes.isList(value) && gristTypes.isListType(col.type.peek())) {
|
||||
const colType = col.type.peek();
|
||||
if (gristTypes.isList(value) && gristTypes.isListType(colType)) {
|
||||
filterValues = value.slice(1);
|
||||
if (!filterValues.length) {
|
||||
// If the list is empty, filter instead by an empty value for the whole list
|
||||
filterValues = [colType === "ChoiceList" ? "" : null];
|
||||
}
|
||||
} else {
|
||||
if (Array.isArray(value)) {
|
||||
value = JSON.stringify(value);
|
||||
|
||||
Reference in New Issue
Block a user