2021-08-20 13:46:59 +00:00
|
|
|
import { ColumnRec, DocModel, TableRec, ViewSectionRec } from 'app/client/models/DocModel';
|
2020-10-02 15:10:00 +00:00
|
|
|
import { IPageWidget } from 'app/client/ui/PageWidgetPicker';
|
2021-08-20 13:46:59 +00:00
|
|
|
import { getReferencedTableId } from 'app/common/gristTypes';
|
2020-10-02 15:10:00 +00:00
|
|
|
import { IOptionFull } from 'grainjs';
|
2022-07-04 14:14:55 +00:00
|
|
|
import assert from 'assert';
|
2022-06-03 12:31:31 +00:00
|
|
|
import * as gutil from "app/common/gutil";
|
2020-10-02 15:10:00 +00:00
|
|
|
|
|
|
|
// some unicode characters
|
|
|
|
const BLACK_CIRCLE = '\u2022';
|
|
|
|
const RIGHT_ARROW = '\u2192';
|
|
|
|
|
|
|
|
// Describes a link
|
|
|
|
export interface IPageWidgetLink {
|
|
|
|
|
|
|
|
// The source section id
|
|
|
|
srcSectionRef: number;
|
|
|
|
|
|
|
|
// The source column id
|
|
|
|
srcColRef: number;
|
|
|
|
|
|
|
|
// The target col id
|
|
|
|
targetColRef: number;
|
|
|
|
}
|
|
|
|
|
|
|
|
export const NoLink = linkId({
|
|
|
|
srcSectionRef: 0,
|
|
|
|
srcColRef: 0,
|
|
|
|
targetColRef: 0
|
|
|
|
});
|
|
|
|
|
|
|
|
const NoLinkOption: IOptionFull<string> = {
|
|
|
|
label: "Select Widget",
|
|
|
|
value: NoLink
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
|
|
interface LinkNode {
|
|
|
|
// the tableId
|
|
|
|
tableId: string;
|
|
|
|
|
|
|
|
// is the table a summary table
|
|
|
|
isSummary: boolean;
|
|
|
|
|
2022-06-03 12:31:31 +00:00
|
|
|
// For a summary table, the set of col refs of the groupby columns of the underlying table
|
|
|
|
groupbyColumns?: Set<number>;
|
|
|
|
|
2020-10-02 15:10:00 +00:00
|
|
|
// list of ids of the sections that are ancestors to this section according to the linked section
|
|
|
|
// relationship
|
|
|
|
ancestors: Set<number>;
|
|
|
|
|
|
|
|
// the section record. Must be the empty record sections that are to be created.
|
|
|
|
section: ViewSectionRec;
|
|
|
|
|
|
|
|
// the column record or undefined for the main section node (ie: the node that does not connect to
|
|
|
|
// any particular column)
|
|
|
|
column?: ColumnRec;
|
|
|
|
|
|
|
|
// the widget type
|
|
|
|
widgetType: string;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2022-06-03 12:31:31 +00:00
|
|
|
// Returns true if this node corresponds to the special 'group' reflist column of a summary table
|
|
|
|
function isSummaryGroup(node: LinkNode): boolean {
|
|
|
|
return node.isSummary && node.column?.colId.peek() === "group";
|
|
|
|
}
|
|
|
|
|
|
|
|
|
2020-10-02 15:10:00 +00:00
|
|
|
// Returns true is the link from `source` to `target` is valid, false otherwise.
|
|
|
|
function isValidLink(source: LinkNode, target: LinkNode) {
|
|
|
|
|
|
|
|
// section must not be the same
|
|
|
|
if (source.section.getRowId() === target.section.getRowId()) {
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
// table must match
|
|
|
|
if (source.tableId !== target.tableId) {
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2022-06-03 12:31:31 +00:00
|
|
|
// Can only link to the somewhat special 'group' reflist column of summary tables
|
|
|
|
// with another ref/reflist column that isn't also a group column
|
|
|
|
// because otherwise it's equivalent to the usual summary table linking but potentially slower
|
|
|
|
if (
|
|
|
|
isSummaryGroup(source) && (!target.column || isSummaryGroup(target)) ||
|
|
|
|
isSummaryGroup(target)
|
|
|
|
) {
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Cannot directly link a summary table to a column referencing the source table.
|
|
|
|
// Instead the ref column must link against the group column of the summary table, which is allowed above.
|
|
|
|
// The 'group' column name will be hidden from the options so it feels like linking using summaryness.
|
|
|
|
if (
|
2022-06-07 11:42:04 +00:00
|
|
|
(source.isSummary && !source.column && target.column) ||
|
|
|
|
(target.isSummary && !target.column && source.column)
|
2022-06-03 12:31:31 +00:00
|
|
|
) {
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
// If the target is a summary table and we're linking based on 'summaryness' (i.e. there are no ref columns)
|
|
|
|
// then the source must be a less detailed summary table, i.e. having a subset of the groupby columns.
|
|
|
|
// (or they should be the same summary table for same-record linking, which this check allows through)
|
2022-05-12 12:59:17 +00:00
|
|
|
if (
|
2022-06-03 12:31:31 +00:00
|
|
|
!source.column &&
|
|
|
|
!target.column &&
|
2022-06-07 11:42:04 +00:00
|
|
|
target.isSummary && !(
|
|
|
|
source.isSummary &&
|
|
|
|
gutil.isSubset(source.groupbyColumns!, target.groupbyColumns!)
|
2022-06-03 12:31:31 +00:00
|
|
|
)
|
2022-05-12 12:59:17 +00:00
|
|
|
) {
|
2020-10-02 15:10:00 +00:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2022-02-01 19:51:40 +00:00
|
|
|
// cannot select from chart
|
|
|
|
if (source.widgetType === 'chart') {
|
2020-10-02 15:10:00 +00:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2022-02-01 19:51:40 +00:00
|
|
|
if (source.widgetType === 'custom') {
|
|
|
|
|
|
|
|
// custom widget do not support linking by columns
|
|
|
|
if (source.tableId !== source.section.table.peek().primaryTableId.peek()) {
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
// custom widget must allow select by
|
|
|
|
if (!source.section.allowSelectBy.get()) {
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2020-10-02 15:10:00 +00:00
|
|
|
// The link must not create a cycle
|
|
|
|
if (source.ancestors.has(target.section.getRowId())) {
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Represents the differents way to reference to a section for linking
|
|
|
|
type MaybeSection = ViewSectionRec|IPageWidget;
|
|
|
|
|
|
|
|
|
|
|
|
// Returns a list of options with all links that link one of the `source` section to the `target`
|
|
|
|
// section. Each `opt.value` is a unique identifier (see: linkId() and linkFromId() for more
|
|
|
|
// detail), and `opt.label` is a human readable representation of the form
|
|
|
|
// `<section_name>[.<source-col-name>][ -> <target-col-name>]` where the <source-col-name> appears
|
|
|
|
// only when linking from a reference column, as opposed to linking from the table directly. And the
|
|
|
|
// <target-col-name> shows only when both <section_name>[.<source-col-name>] is ambiguous.
|
|
|
|
export function selectBy(docModel: DocModel, sources: ViewSectionRec[],
|
|
|
|
target: MaybeSection): Array<IOptionFull<string>> {
|
|
|
|
const sourceNodes = createNodes(docModel, sources);
|
|
|
|
const targetNodes = createNodes(docModel, [target]);
|
|
|
|
|
|
|
|
const options = [NoLinkOption];
|
|
|
|
for (const srcNode of sourceNodes) {
|
|
|
|
const validTargets = targetNodes.filter((tgt) => isValidLink(srcNode, tgt));
|
|
|
|
const hasMany = validTargets.length > 1;
|
|
|
|
for (const tgtNode of validTargets) {
|
|
|
|
|
|
|
|
// a unique identifier for this link
|
|
|
|
const value = linkId({
|
|
|
|
srcSectionRef: srcNode.section.getRowId(),
|
|
|
|
srcColRef: srcNode.column ? srcNode.column.getRowId() : 0,
|
|
|
|
targetColRef: tgtNode.column ? tgtNode.column.getRowId() : 0,
|
|
|
|
});
|
|
|
|
|
|
|
|
// a human readable description
|
|
|
|
let label = srcNode.section.titleDef();
|
|
|
|
|
2022-06-03 12:31:31 +00:00
|
|
|
// add the source node col name (except for 'group') or nothing for table node
|
|
|
|
if (srcNode.column && !isSummaryGroup(srcNode)) {
|
|
|
|
label += ` ${BLACK_CIRCLE} ${srcNode.column.label.peek()}`;
|
|
|
|
}
|
2020-10-02 15:10:00 +00:00
|
|
|
|
2022-06-07 11:42:04 +00:00
|
|
|
// add the target column name (except for 'group') when clarification is needed, i.e. if either:
|
|
|
|
// - target has multiple valid nodes, or
|
|
|
|
// - source col is 'group' and is thus hidden.
|
|
|
|
// Need at least one column name to distinguish from simply selecting by summary table.
|
|
|
|
// This is relevant when a table has a column referencing itself.
|
|
|
|
if (tgtNode.column && !isSummaryGroup(tgtNode) && (hasMany || isSummaryGroup(srcNode))) {
|
2022-06-03 12:31:31 +00:00
|
|
|
label += ` ${RIGHT_ARROW} ${tgtNode.column.label.peek()}`;
|
|
|
|
}
|
2020-10-02 15:10:00 +00:00
|
|
|
|
|
|
|
// add the new option
|
|
|
|
options.push({ label, value });
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return options;
|
|
|
|
}
|
|
|
|
|
|
|
|
function isViewSectionRec(section: MaybeSection): section is ViewSectionRec {
|
|
|
|
return Boolean((section as ViewSectionRec).getRowId);
|
|
|
|
}
|
|
|
|
|
|
|
|
// Create all nodes for sections.
|
|
|
|
function createNodes(docModel: DocModel, sections: MaybeSection[]) {
|
|
|
|
const nodes = [];
|
|
|
|
for (const section of sections) {
|
|
|
|
if (isViewSectionRec(section)) {
|
|
|
|
nodes.push(...fromViewSectionRec(section));
|
|
|
|
} else {
|
|
|
|
nodes.push(...fromPageWidget(docModel, section));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return nodes;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Creates an array of LinkNode from a view section record.
|
|
|
|
function fromViewSectionRec(section: ViewSectionRec): LinkNode[] {
|
2022-03-24 18:33:53 +00:00
|
|
|
if (section.isDisposed()) {
|
|
|
|
return [];
|
|
|
|
}
|
2020-10-02 15:10:00 +00:00
|
|
|
const table = section.table.peek();
|
|
|
|
const ancestors = new Set<number>();
|
|
|
|
|
|
|
|
for (let sec = section; sec.getRowId(); sec = sec.linkSrcSection.peek()) {
|
|
|
|
if (ancestors.has(sec.getRowId())) {
|
|
|
|
// tslint:disable-next-line:no-console
|
|
|
|
console.warn(`Links should not create a cycle - section ids: ${Array.from(ancestors)}`);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
ancestors.add(sec.getRowId());
|
|
|
|
}
|
|
|
|
|
2022-06-03 12:31:31 +00:00
|
|
|
const isSummary = table.primaryTableId.peek() !== table.tableId.peek();
|
|
|
|
const mainNode: LinkNode = {
|
2020-10-02 15:10:00 +00:00
|
|
|
tableId: table.primaryTableId.peek(),
|
2022-06-03 12:31:31 +00:00
|
|
|
isSummary,
|
|
|
|
groupbyColumns: isSummary ? table.summarySourceColRefs.peek() : undefined,
|
2020-10-02 15:10:00 +00:00
|
|
|
widgetType: section.parentKey.peek(),
|
|
|
|
ancestors,
|
|
|
|
section,
|
|
|
|
};
|
|
|
|
|
2021-08-20 13:46:59 +00:00
|
|
|
return fromColumns(table, mainNode);
|
2020-10-02 15:10:00 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// Creates an array of LinkNode from a page widget.
|
|
|
|
function fromPageWidget(docModel: DocModel, pageWidget: IPageWidget): LinkNode[] {
|
|
|
|
|
|
|
|
if (typeof pageWidget.table !== 'number') { return []; }
|
|
|
|
|
|
|
|
const table = docModel.tables.getRowModel(pageWidget.table);
|
2022-06-03 12:31:31 +00:00
|
|
|
const isSummary = pageWidget.summarize;
|
2020-10-02 15:10:00 +00:00
|
|
|
const mainNode: LinkNode = {
|
|
|
|
tableId: table.primaryTableId.peek(),
|
2022-06-03 12:31:31 +00:00
|
|
|
isSummary,
|
|
|
|
groupbyColumns: isSummary ? new Set(pageWidget.columns) : undefined,
|
2020-10-02 15:10:00 +00:00
|
|
|
widgetType: pageWidget.type,
|
|
|
|
ancestors: new Set(),
|
|
|
|
section: docModel.viewSections.getRowModel(pageWidget.section),
|
|
|
|
};
|
|
|
|
|
2021-08-20 13:46:59 +00:00
|
|
|
return fromColumns(table, mainNode);
|
|
|
|
}
|
2020-10-02 15:10:00 +00:00
|
|
|
|
2021-08-20 13:46:59 +00:00
|
|
|
function fromColumns(table: TableRec, mainNode: LinkNode): LinkNode[] {
|
|
|
|
const nodes = [mainNode];
|
|
|
|
const columns = table.columns.peek().peek();
|
2020-10-02 15:10:00 +00:00
|
|
|
for (const column of columns) {
|
2021-08-20 13:46:59 +00:00
|
|
|
const tableId = getReferencedTableId(column.type.peek());
|
2020-10-02 15:10:00 +00:00
|
|
|
if (tableId) {
|
|
|
|
nodes.push({...mainNode, tableId, column});
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return nodes;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Returns an identifier to uniquely identify a link. Here we adopt a simple approach where
|
|
|
|
// {srcSectionRef: 2, srcColRef: 3, targetColRef: 3} is turned into "[2, 3, 3]".
|
|
|
|
export function linkId(link: IPageWidgetLink) {
|
|
|
|
return JSON.stringify([link.srcSectionRef, link.srcColRef, link.targetColRef]);
|
|
|
|
}
|
|
|
|
|
|
|
|
// Returns link's properties from its identifier.
|
(core) Add other direction of linking by reflist
Summary:
Allows selecting by a reflist in another table. This generalises cursor-linking with a ref column, but now it's filter linking.
Added another case to LinkingState where the source column is a reflist to the target table, filtering by the id column.
Updated convertQueryFromRefs and related functions to handle this since the id column has no column ref. In this case the string 'id' is used instead of a number.
LinkingState also checks if the source value is a reflist and uses that as the list of filter values instead of a single-element list of the cell value.
Indirect linking also works, where the source and target columns both are both references to the same table. This was the plan for a source reflist and target ref column.
I was surprised to see it also works perfectly when both columns are reflists, and it filters rows where there's an intersection!
Adding rows to the target section using the selected source record for default values is iffy. When filtering by row ID, there's no column for defaults, so the new row disappears.
For a source reflist and target ref, the first value of the reflist is the default, which is okayish. When both are reflists, the full source reflist is the default for the target column.
This seems like a bit much but just using the first value seems a bit arbitrary when there's room for all of them?
While doing all this I noticed an unrelated bug which I fixed as I was refactoring. Previously cursor linking based on a reference column did not update the cursor in the link target
when the value of the selected reference cell changed. Now cursor linking uses a floating row model like most other cases to observe the value correctly.
Test Plan: Extended SelectByRefList test and fixture, added previously failing test to RightPanelSelectBy.
Reviewers: dsagal
Reviewed By: dsagal
Differential Revision: https://phab.getgrist.com/D3004
2021-08-30 13:29:39 +00:00
|
|
|
export function linkFromId(linkid: string): IPageWidgetLink {
|
2020-10-02 15:10:00 +00:00
|
|
|
const [srcSectionRef, srcColRef, targetColRef] = JSON.parse(linkid);
|
|
|
|
return {srcSectionRef, srcColRef, targetColRef};
|
|
|
|
}
|
(core) When changing a table for a page widget, unset widget-linking to avoid invalid values.
Summary:
Previously, using "Change Widget" allowed one to change the underlying table,
but would keep the linking settings. This could allow invalid settings which
would sometimes lead to JS errors. These manifested in production as
"UserError: Query error: n is not a function".
- Unset linking settings in this case, to avoid invalid values.
- In case invalid values are encountered (e.g. saved previously), treat them as
unset, to avoid JS errors.
- If an error does occur, report it with a stack trace.
Also, for testing, added 'selectBy' option to gristUtils helpers for using page-widget-picker.
Test Plan: Added test cases for resetting linking, and for ignoring invalid link settings.
Reviewers: alexmojaki
Reviewed By: alexmojaki
Differential Revision: https://phab.getgrist.com/D2993
2021-08-24 03:28:07 +00:00
|
|
|
|
|
|
|
export class LinkConfig {
|
|
|
|
public readonly srcSection: ViewSectionRec;
|
|
|
|
public readonly tgtSection: ViewSectionRec;
|
|
|
|
// Note that srcCol and tgtCol may be the empty column records if that column is not used.
|
|
|
|
public readonly srcCol: ColumnRec;
|
|
|
|
public readonly tgtCol: ColumnRec;
|
|
|
|
public readonly srcColId: string|undefined;
|
|
|
|
public readonly tgtColId: string|undefined;
|
|
|
|
|
|
|
|
// The constructor throws an exception if settings are invalid. When used from inside a knockout
|
|
|
|
// computed, the constructor subscribes to all parts relevant for linking.
|
|
|
|
constructor(tgtSection: ViewSectionRec) {
|
|
|
|
this.tgtCol = tgtSection.linkTargetCol();
|
|
|
|
this.srcCol = tgtSection.linkSrcCol();
|
|
|
|
this.srcSection = tgtSection.linkSrcSection();
|
|
|
|
this.tgtSection = tgtSection;
|
|
|
|
this.srcColId = this.srcCol.colId();
|
|
|
|
this.tgtColId = this.tgtCol.colId();
|
|
|
|
this._assertValid();
|
|
|
|
}
|
|
|
|
|
|
|
|
// Check if section-linking configuration is valid, and throw exception if not.
|
|
|
|
private _assertValid(): void {
|
|
|
|
// Use null for unset cols (rather than an empty ColumnRec) for easier comparisons below.
|
|
|
|
const srcCol = this.srcCol?.getRowId() ? this.srcCol : null;
|
|
|
|
const tgtCol = this.tgtCol?.getRowId() ? this.tgtCol : null;
|
2022-04-07 15:18:20 +00:00
|
|
|
const srcTableId = (srcCol ? getReferencedTableId(srcCol.type()) :
|
|
|
|
this.srcSection.table().primaryTableId());
|
|
|
|
const tgtTableId = (tgtCol ? getReferencedTableId(tgtCol.type()) :
|
|
|
|
this.tgtSection.table().primaryTableId());
|
(core) When changing a table for a page widget, unset widget-linking to avoid invalid values.
Summary:
Previously, using "Change Widget" allowed one to change the underlying table,
but would keep the linking settings. This could allow invalid settings which
would sometimes lead to JS errors. These manifested in production as
"UserError: Query error: n is not a function".
- Unset linking settings in this case, to avoid invalid values.
- In case invalid values are encountered (e.g. saved previously), treat them as
unset, to avoid JS errors.
- If an error does occur, report it with a stack trace.
Also, for testing, added 'selectBy' option to gristUtils helpers for using page-widget-picker.
Test Plan: Added test cases for resetting linking, and for ignoring invalid link settings.
Reviewers: alexmojaki
Reviewed By: alexmojaki
Differential Revision: https://phab.getgrist.com/D2993
2021-08-24 03:28:07 +00:00
|
|
|
try {
|
2022-04-07 15:18:20 +00:00
|
|
|
assert(Boolean(this.srcSection.getRowId()), "srcSection was disposed");
|
|
|
|
assert(!tgtCol || tgtCol.parentId() === this.tgtSection.tableRef(), "tgtCol belongs to wrong table");
|
|
|
|
assert(!srcCol || srcCol.parentId() === this.srcSection.tableRef(), "srcCol belongs to wrong table");
|
(core) When changing a table for a page widget, unset widget-linking to avoid invalid values.
Summary:
Previously, using "Change Widget" allowed one to change the underlying table,
but would keep the linking settings. This could allow invalid settings which
would sometimes lead to JS errors. These manifested in production as
"UserError: Query error: n is not a function".
- Unset linking settings in this case, to avoid invalid values.
- In case invalid values are encountered (e.g. saved previously), treat them as
unset, to avoid JS errors.
- If an error does occur, report it with a stack trace.
Also, for testing, added 'selectBy' option to gristUtils helpers for using page-widget-picker.
Test Plan: Added test cases for resetting linking, and for ignoring invalid link settings.
Reviewers: alexmojaki
Reviewed By: alexmojaki
Differential Revision: https://phab.getgrist.com/D2993
2021-08-24 03:28:07 +00:00
|
|
|
assert(this.srcSection.getRowId() !== this.tgtSection.getRowId(), "srcSection links to itself");
|
|
|
|
assert(tgtTableId, "tgtCol not a valid reference");
|
|
|
|
assert(srcTableId, "srcCol not a valid reference");
|
|
|
|
assert(srcTableId === tgtTableId, "mismatched tableIds");
|
|
|
|
} catch (e) {
|
|
|
|
throw new Error(`LinkConfig invalid: ` +
|
|
|
|
`${this.srcSection.getRowId()}:${this.srcCol?.getRowId()}[${srcTableId}] -> ` +
|
|
|
|
`${this.tgtSection.getRowId()}:${this.tgtCol?.getRowId()}[${tgtTableId}]: ${e}`);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|