1
0
mirror of https://github.com/falk-werner/webfuse synced 2025-06-13 12:54:15 +00:00

fixes javascript style issues

This commit is contained in:
Falk Werner 2019-04-14 19:34:52 +02:00
parent 8ffaa1b366
commit 0311bfff1d
2 changed files with 13 additions and 10 deletions

View File

@ -74,12 +74,11 @@ export class ConnectionView {
_onConnectionOpened() { _onConnectionOpened() {
if (this.authenticateCheckbox.checked) { if (this.authenticateCheckbox.checked) {
console.log("authenticate");
const username = this.usernameTextbox.value; const username = this.usernameTextbox.value;
const password = this.passwordTextbox.value; const password = this.passwordTextbox.value;
const promise = this._client.authenticate("username", { username, password }); const promise = this._client.authenticate("username", { username, password });
promise.then(() => { this._client.addProvider("test", this._provider) }); promise.then(() => { this._client.addProvider("test", this._provider); });
} else { } else {
this._client.addProvider("test", this._provider); this._client.addProvider("test", this._provider);
} }

View File

@ -27,15 +27,14 @@ export class Client {
} }
_invokeRequest(method, params) { _invokeRequest(method, params) {
const id = ++this._id; this._id++;
const id = this._id;
const request = {method, params, id}; const request = {method, params, id};
return new Promise((resolve, reject) => { return new Promise((resolve, reject) => {
this._pendingRequests[id] = {resolve, reject}; this._pendingRequests[id] = {resolve, reject};
this._ws.send(JSON.stringify(request)); this._ws.send(JSON.stringify(request));
}) });
} }
authenticate(type, credentials) { authenticate(type, credentials) {
@ -67,19 +66,19 @@ export class Client {
_isRequest(request) { _isRequest(request) {
const method = request.method; const method = request.method;
return (("string" === typeof(method)) && (request.hasOwnProperty("params"))); return (("string" === typeof(method)) && ("params" in request));
} }
_isResponse(response) { _isResponse(response) {
const id = response.id; const id = response.id;
return (("number" === typeof(id)) && (response.hasOwnProperty("result") || response.hasOwnProperty("error"))); return (("number" === typeof(id)) && (("result" in response) || ("error" in response)));
} }
_removePendingRequest(id) { _removePendingRequest(id) {
let result = null; let result = null;
if (this._pendingRequests.hasOwnProperty(id)) { if (id in this._pendingRequests) {
result = this._pendingRequests[id]; result = this._pendingRequests[id];
delete this._pendingRequests[id]; delete this._pendingRequests[id];
} }
@ -168,7 +167,7 @@ export class Client {
} }
_getProvider(name) { _getProvider(name) {
if (this._provider.hasOwnProperty(name)) { if (name in this._provider) {
return this._provider[name]; return this._provider[name];
} }
else { else {
@ -178,26 +177,31 @@ export class Client {
async _lookup([providerName, parent, name]) { async _lookup([providerName, parent, name]) {
const provider = this._getProvider(providerName); const provider = this._getProvider(providerName);
return provider.lookup(parent, name); return provider.lookup(parent, name);
} }
async _getattr([providerName, inode]) { async _getattr([providerName, inode]) {
const provider = this._getProvider(providerName); const provider = this._getProvider(providerName);
return provider.getattr(inode); return provider.getattr(inode);
} }
async _readdir([providerName, inode]) { async _readdir([providerName, inode]) {
const provider = this._getProvider(providerName); const provider = this._getProvider(providerName);
return provider.readdir(inode); return provider.readdir(inode);
} }
async _open([providerName, inode, mode]) { async _open([providerName, inode, mode]) {
const provider = this._getProvider(providerName); const provider = this._getProvider(providerName);
return provider.open(inode, mode); return provider.open(inode, mode);
} }
_close([providerName, inode, handle, mode]) { _close([providerName, inode, handle, mode]) {
const provider = this._getProvider(providerName); const provider = this._getProvider(providerName);
provider.close(inode, handle, mode); provider.close(inode, handle, mode);
} }