Archives/Athou_commafeed
1
0
Fork 1
mirror of https://github.com/Athou/commafeed.git synced 2026-03-21 21:37:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

initial entry caching implementation

Browse Source
This commit is contained in:
Athou
2013-06-28 17:02:29 +02:00
parent 25bc35ef14
commit fbd0feb6e7
2 changed files with 42 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
src/main/java/com/commafeed/backend/cache/CacheService.java vendored Normal file
View File

@@ -0,0 +1,31 @@
package com.commafeed.backend.cache;
import java.util.concurrent.TimeUnit;
import com.commafeed.backend.model.Feed;
import com.commafeed.backend.model.FeedEntry;
import com.google.common.cache.Cache;
import com.google.common.cache.CacheBuilder;
public class CacheService {
Cache<String, Marker> entryCache = CacheBuilder.newBuilder()
.maximumSize(1000000).expireAfterWrite(24, TimeUnit.HOURS).build();
private static enum Marker {
INSTANCE
}
public boolean hasFeedEntry(Feed feed, FeedEntry entry) {
return entryCache.getIfPresent(buildKey(feed, entry)) == Marker.INSTANCE;
}
public void putFeedEntry(Feed feed, FeedEntry entry) {
entryCache.put(buildKey(feed, entry), Marker.INSTANCE);
}
private String buildKey(Feed feed, FeedEntry entry) {
return String.format("%s:%s:%s", feed.getId(), entry.getGuid(),
entry.getUrl());
}
}

12
src/main/java/com/commafeed/backend/feeds/FeedRefreshUpdater.java
View File

@@ -20,6 +20,7 @@ import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import com.commafeed.backend.MetricsBean;
import com.commafeed.backend.cache.CacheService;
import com.commafeed.backend.dao.FeedDAO;
import com.commafeed.backend.dao.FeedEntryDAO;
import com.commafeed.backend.dao.FeedSubscriptionDAO;
@@ -62,6 +63,9 @@ public class FeedRefreshUpdater {
@Inject
FeedEntryDAO feedEntryDAO;
@Inject
CacheService cache;
private ThreadPoolExecutor pool;
private Striped<Lock> locks;
private LinkedBlockingDeque<Runnable> queue;
@@ -167,7 +171,13 @@ public class FeedRefreshUpdater {
try {
locked = lock.tryLock(1, TimeUnit.MINUTES);
if (locked) {
feedUpdateService.updateEntry(feed, entry, subscriptions);
if (!cache.hasFeedEntry(feed, entry)) {
log.info("cache miss for {}", entry.getUrl());
feedUpdateService.updateEntry(feed, entry, subscriptions);
cache.putFeedEntry(feed, entry);
} else {
log.info("cache hit for {}", entry.getUrl());
}
success = true;
} else {
log.error("lock timeout for " + feed.getUrl() + " - " + key);