don't delete in a big transaction

This commit is contained in:
Athou
2013-06-16 16:32:46 +02:00
parent c2f0efb448
commit e6a091d351
3 changed files with 9 additions and 17 deletions

View File

@@ -1,16 +1,12 @@
package com.commafeed.backend;
import java.util.Calendar;
import java.util.List;
import java.util.concurrent.TimeUnit;
import javax.ejb.Stateless;
import javax.inject.Inject;
import com.commafeed.backend.dao.FeedEntryDAO;
import com.commafeed.backend.model.FeedEntry;
@Stateless
public class DatabaseCleaner {
@Inject
@@ -22,15 +18,7 @@ public class DatabaseCleaner {
int deleted = -1;
do {
List<FeedEntry> entries = feedEntryDAO.findByInserted(
cal.getTime(), 100);
deleted = entries.size();
for (FeedEntry entry : entries) {
feedEntryDAO.delete(entry.getStatuses());
}
feedEntryDAO.delete(entries);
deleted = feedEntryDAO.delete(cal.getTime(), 1000);
} while (deleted != 0);
}

View File

@@ -56,14 +56,18 @@ public class FeedEntryDAO extends GenericDAO<FeedEntry> {
return list;
}
public List<FeedEntry> findByInserted(Date olderThan, int max) {
public int delete(Date olderThan, int max) {
CriteriaQuery<FeedEntry> query = builder.createQuery(getType());
Root<FeedEntry> root = query.from(getType());
query.where(builder.lessThan(root.get(FeedEntry_.inserted), olderThan));
TypedQuery<FeedEntry> q = em.createQuery(query);
q.setMaxResults(max);
return q.getResultList();
List<FeedEntry> list = q.getResultList();
int deleted = list.size();
em.remove(list);
return deleted;
}
public List<FeedEntry> findByFeed(Feed feed, int offset, int limit) {

View File

@@ -49,7 +49,7 @@ public class FeedEntry extends AbstractModel {
@Temporal(TemporalType.TIMESTAMP)
private Date updated;
@OneToMany(mappedBy = "entry")
@OneToMany(mappedBy = "entry", cascade = CascadeType.REMOVE)
private Set<FeedEntryStatus> statuses;
public String getGuid() {