prevent XXS in third party apps

CommaFeed React client already strips malicious "javascript:" urls but we might as well not store those in the database
This commit is contained in:
Athou
2026-08-03 08:22:43 +02:00
parent b9eceaae73
commit bc6e767953
3 changed files with 58 additions and 7 deletions

View File

@@ -93,6 +93,35 @@ class UrlsTest {
"https://www.berliner-zeitung.de/feed.xml"));
}
@Test
void testSanitize() {
// valid http/https urls are kept as is
Assertions.assertEquals("http://example.com/foo", Urls.sanitize("http://example.com/foo"));
Assertions.assertEquals(
"https://example.com/foo", Urls.sanitize("https://example.com/foo"));
// scheme matching is case-insensitive
Assertions.assertEquals("HTTP://example.com/foo", Urls.sanitize("HTTP://example.com/foo"));
Assertions.assertEquals(
"HTTPS://example.com/foo", Urls.sanitize("HTTPS://example.com/foo"));
// malicious or disallowed schemes are stripped
Assertions.assertNull(Urls.sanitize("javascript:alert(1)"));
Assertions.assertNull(Urls.sanitize("JavaScript:alert(1)"));
Assertions.assertNull(Urls.sanitize("data:text/html,<script>alert(1)</script>"));
Assertions.assertNull(Urls.sanitize("mailto:foo@example.com"));
Assertions.assertNull(Urls.sanitize("ftp://example.com/foo"));
// relative and protocol-relative urls are not considered valid
Assertions.assertNull(Urls.sanitize("/blog/entry/1"));
Assertions.assertNull(Urls.sanitize("//example.com/foo"));
// null and blank input
Assertions.assertNull(Urls.sanitize(null));
Assertions.assertNull(Urls.sanitize(""));
Assertions.assertNull(Urls.sanitize(" "));
}
@Test
void testRemoveTrailingSlash() {
final String url = "http://localhost/";