split client and server into maven modules

commafeed-server/src/test/java/com/commafeed/frontend/auth/SecurityCheckFactoryTest.java

@@ -0,0 +1,32 @@
+package com.commafeed.frontend.auth;
+
+import java.util.Optional;
+
+import org.junit.jupiter.api.Test;
+import org.mockito.Mockito;
+
+import com.commafeed.backend.model.User;
+import com.commafeed.backend.service.UserService;
+import com.commafeed.backend.service.internal.PostLoginActivities;
+import com.commafeed.frontend.session.SessionHelper;
+
+class SecurityCheckFactoryTest {
+
+	@Test
+	void cookieLoginShouldPerformPostLoginActivities() {
+		User userInSession = new User();
+
+		SessionHelper sessionHelper = Mockito.mock(SessionHelper.class);
+		Mockito.when(sessionHelper.getLoggedInUser()).thenReturn(Optional.of(userInSession));
+
+		PostLoginActivities postLoginActivities = Mockito.mock(PostLoginActivities.class);
+
+		UserService service = new UserService(null, null, null, null, null, null, null, postLoginActivities);
+
+		SecurityCheckFactory factory = new SecurityCheckFactory(service, null, null, false);
+		factory.cookieSessionLogin(sessionHelper);
+
+		Mockito.verify(postLoginActivities).executeFor(userInSession);
+	}
+
+}

commafeed-server/src/test/java/com/commafeed/frontend/resource/UserRestTest.java

@@ -0,0 +1,107 @@
+package com.commafeed.frontend.resource;
+
+import java.util.Arrays;
+import java.util.Optional;
+
+import org.junit.jupiter.api.Test;
+import org.mockito.ArgumentMatchers;
+import org.mockito.InOrder;
+import org.mockito.Mockito;
+
+import com.commafeed.backend.model.User;
+import com.commafeed.backend.model.UserRole.Role;
+import com.commafeed.backend.service.UserService;
+import com.commafeed.frontend.model.request.LoginRequest;
+import com.commafeed.frontend.model.request.RegistrationRequest;
+import com.commafeed.frontend.session.SessionHelper;
+
+class UserRestTest {
+
+	@Test
+	void loginShouldNotPopulateHttpSessionIfUnsuccessfull() {
+		// Absent user
+		Optional<User> absentUser = Optional.empty();
+
+		// Create UserService partial mock
+		UserService service = Mockito.mock(UserService.class);
+		Mockito.when(service.login("user", "password")).thenReturn(absentUser);
+
+		UserREST userREST = new UserREST(null, null, null, service, null, null, null);
+		SessionHelper sessionHelper = Mockito.mock(SessionHelper.class);
+
+		LoginRequest req = new LoginRequest();
+		req.setName("user");
+		req.setPassword("password");
+
+		userREST.login(req, sessionHelper);
+
+		Mockito.verify(sessionHelper, Mockito.never()).setLoggedInUser(Mockito.any(User.class));
+	}
+
+	@Test
+	void loginShouldPopulateHttpSessionIfSuccessfull() {
+		// Create a user
+		User user = new User();
+
+		// Create UserService mock
+		UserService service = Mockito.mock(UserService.class);
+		Mockito.when(service.login("user", "password")).thenReturn(Optional.of(user));
+
+		LoginRequest req = new LoginRequest();
+		req.setName("user");
+		req.setPassword("password");
+
+		UserREST userREST = new UserREST(null, null, null, service, null, null, null);
+		SessionHelper sessionHelper = Mockito.mock(SessionHelper.class);
+
+		userREST.login(req, sessionHelper);
+
+		Mockito.verify(sessionHelper).setLoggedInUser(user);
+	}
+
+	@Test
+	void registerShouldRegisterAndThenLogin() {
+		// Create UserService mock
+		UserService service = Mockito.mock(UserService.class);
+
+		RegistrationRequest req = new RegistrationRequest();
+		req.setName("user");
+		req.setPassword("password");
+		req.setEmail("test@test.com");
+
+		InOrder inOrder = Mockito.inOrder(service);
+
+		SessionHelper sessionHelper = Mockito.mock(SessionHelper.class);
+		UserREST userREST = new UserREST(null, null, null, service, null, null, null);
+
+		userREST.registerUser(req, sessionHelper);
+
+		inOrder.verify(service).register("user", "password", "test@test.com", Arrays.asList(Role.USER));
+		inOrder.verify(service).login("user", "password");
+	}
+
+	@Test
+	void registerShouldPopulateHttpSession() {
+		// Create a user
+		User user = new User();
+
+		// Create UserService mock
+		UserService service = Mockito.mock(UserService.class);
+		Mockito.when(service.register(Mockito.any(String.class), Mockito.any(String.class), Mockito.any(String.class),
+				ArgumentMatchers.anyList())).thenReturn(user);
+		Mockito.when(service.login(Mockito.any(String.class), Mockito.any(String.class))).thenReturn(Optional.of(user));
+
+		RegistrationRequest req = new RegistrationRequest();
+		req.setName("user");
+		req.setPassword("password");
+		req.setEmail("test@test.com");
+
+		SessionHelper sessionHelper = Mockito.mock(SessionHelper.class);
+		UserREST userREST = new UserREST(null, null, null, service, null, null, null);
+
+		userREST.registerUser(req, sessionHelper);
+
+		Mockito.verify(sessionHelper).setLoggedInUser(user);
+	}
+
+}

commafeed-server/src/test/java/com/commafeed/frontend/session/SessionHelperTest.java

@@ -0,0 +1,70 @@
+package com.commafeed.frontend.session;
+
+import java.util.Optional;
+
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpSession;
+
+import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.Test;
+import org.mockito.Mockito;
+
+import com.commafeed.backend.model.User;
+
+class SessionHelperTest {
+
+	private static final String SESSION_KEY_USER = "user";
+
+	@Test
+	void gettingUserDoesNotCreateSession() {
+		HttpServletRequest request = Mockito.mock(HttpServletRequest.class);
+
+		SessionHelper sessionHelper = new SessionHelper(request);
+		sessionHelper.getLoggedInUser();
+
+		Mockito.verify(request).getSession(false);
+	}
+
+	@Test
+	void gettingUserShouldNotReturnUserIfThereIsNoPreexistingHttpSession() {
+		HttpServletRequest request = Mockito.mock(HttpServletRequest.class);
+		Mockito.when(request.getSession(false)).thenReturn(null);
+
+		SessionHelper sessionHelper = new SessionHelper(request);
+		Optional<User> user = sessionHelper.getLoggedInUser();
+
+		Assertions.assertFalse(user.isPresent());
+	}
+
+	@Test
+	void gettingUserShouldNotReturnUserIfUserNotPresentInHttpSession() {
+		HttpSession session = Mockito.mock(HttpSession.class);
+		Mockito.when(session.getAttribute(SESSION_KEY_USER)).thenReturn(null);
+
+		HttpServletRequest request = Mockito.mock(HttpServletRequest.class);
+		Mockito.when(request.getSession(false)).thenReturn(session);
+
+		SessionHelper sessionHelper = new SessionHelper(request);
+		Optional<User> user = sessionHelper.getLoggedInUser();
+
+		Assertions.assertFalse(user.isPresent());
+	}
+
+	@Test
+	void gettingUserShouldReturnUserIfUserPresentInHttpSession() {
+		User userInSession = new User();
+
+		HttpSession session = Mockito.mock(HttpSession.class);
+		Mockito.when(session.getAttribute(SESSION_KEY_USER)).thenReturn(userInSession);
+
+		HttpServletRequest request = Mockito.mock(HttpServletRequest.class);
+		Mockito.when(request.getSession(false)).thenReturn(session);
+
+		SessionHelper sessionHelper = new SessionHelper(request);
+		Optional<User> user = sessionHelper.getLoggedInUser();
+
+		Assertions.assertTrue(user.isPresent());
+		Assertions.assertEquals(userInSession, user.get());
+	}
+
+}