requeue feed immediatly if an entry fails to update

This commit is contained in:
Athou
2013-05-27 12:16:37 +02:00
parent 648923afb8
commit 8c45fc41ec

View File

@@ -69,7 +69,7 @@ public class FeedRefreshUpdater {
locks = Striped.lazyWeakLock(threads);
pool = new ThreadPoolExecutor(threads, threads, 0,
TimeUnit.MILLISECONDS,
queue = new ArrayBlockingQueue<Runnable>(100 * threads));
queue = new ArrayBlockingQueue<Runnable>(500 * threads));
pool.setRejectedExecutionHandler(new RejectedExecutionHandler() {
@Override
public void rejectedExecution(Runnable r, ThreadPoolExecutor e) {
@@ -111,35 +111,43 @@ public class FeedRefreshUpdater {
@Override
public void run() {
boolean ok = true;
if (entries != null) {
List<FeedSubscription> subscriptions = feedSubscriptionDAO
.findByFeed(feed);
for (FeedEntry entry : entries) {
updateEntry(feed, entry, subscriptions);
ok &= updateEntry(feed, entry, subscriptions);
}
}
if (applicationSettingsService.get().isPubsubhubbub()) {
handlePubSub(feed);
}
if (!ok) {
feed.setDisabledUntil(null);
}
metricsBean.feedUpdated();
taskGiver.giveBack(feed);
}
}
private void updateEntry(final Feed feed, final FeedEntry entry,
private boolean updateEntry(final Feed feed, final FeedEntry entry,
final List<FeedSubscription> subscriptions) {
Lock lock = locks.get(entry.getGuid());
boolean locked = false;
try {
lock.tryLock(1, TimeUnit.MINUTES);
locked = lock.tryLock(1, TimeUnit.MINUTES);
feedUpdateService.updateEntry(feed, entry, subscriptions);
} catch (InterruptedException e) {
log.error("interrupted while waiting for lock for " + feed.getUrl()
+ " : " + e.getMessage(), e);
} finally {
lock.unlock();
if (locked) {
lock.unlock();
}
}
return locked;
}
private void handlePubSub(final Feed feed) {